Skip to content

net/mlx5e: Extend XDP multi-buffer capabilities

Tariq Toukan netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15net/mlx5e: Move XDP struct and enum to XDP headerdrivers/net/ethernet/mellanox/mlx5/core/en.h drivers/net/ethernet/mellanox/mlx5/core/en/xdp.h+35 -350 replies
2/15net/mlx5e: Move struct mlx5e_xmit_data to datapath headerdrivers/net/ethernet/mellanox/mlx5/core/en.h drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h+7 -60 replies
3/15net/mlx5e: Introduce extended version for mlx5e_xmit_datadrivers/net/ethernet/mellanox/mlx5/core/en.h drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c +2 more+44 -340 replies
4/15net/mlx5e: XDP, Remove doubtful unlikely callsdrivers/net/ethernet/mellanox/mlx5/core/en/xdp.c+5 -50 replies
5/15net/mlx5e: XDP, Use multiple single-entry objects in xdpi_fifodrivers/net/ethernet/mellanox/mlx5/core/en.h drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c drivers/net/ethernet/mellanox/mlx5/core/en/xdp.h +2 more+101 -500 replies
6/15net/mlx5e: XDP, Add support for multi-buffer XDP redirect-indrivers/net/ethernet/mellanox/mlx5/core/en/txrx.h drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c drivers/net/ethernet/mellanox/mlx5/core/en_main.c+75 -170 replies
7/15net/mlx5e: XDP, Improve Striding RQ check with XDPdrivers/net/ethernet/mellanox/mlx5/core/en_main.c+9 -140 replies
8/15net/mlx5e: XDP, Let XDP checker function get the params as inputdrivers/net/ethernet/mellanox/mlx5/core/en_main.c+8 -130 replies
9/15net/mlx5e: XDP, Consider large muti-buffer packets in Striding RQ params calculationsdrivers/net/ethernet/mellanox/mlx5/core/en/params.c+7 -40 replies
10/15net/mlx5e: XDP, Remove un-established assumptions on XDP bufferdrivers/net/ethernet/mellanox/mlx5/core/en/xdp.c drivers/net/ethernet/mellanox/mlx5/core/en_main.c+22 -180 replies
11/15net/mlx5e: XDP, Allow non-linear single-segment frames in XDP TX MPWQEdrivers/net/ethernet/mellanox/mlx5/core/en/xdp.c+26 -90 replies
12/15net/mlx5e: RX, Take shared info fragment addition into a functiondrivers/net/ethernet/mellanox/mlx5/core/en_rx.c+31 -250 replies
13/15net/mlx5e: RX, Generalize mlx5e_fill_mxbuf()drivers/net/ethernet/mellanox/mlx5/core/en_rx.c+8 -50 replies
14/15net/mlx5e: RX, Prepare non-linear striding RQ for XDP multi-buffer supportdrivers/net/ethernet/mellanox/mlx5/core/en_rx.c+47 -40 replies
15/15net/mlx5e: RX, Add XDP multi-buffer support in Striding RQdrivers/net/ethernet/mellanox/mlx5/core/en.h drivers/net/ethernet/mellanox/mlx5/core/en/params.c drivers/net/ethernet/mellanox/mlx5/core/en/params.h +2 more+138 -590 replies

Reviews trailers per patch

12 of 15 patches have a Reviewed-by or Acked-by.

PatchSaeed MahameedGal Pressman
1/15R-b
2/15R-b
3/15
4/15R-b
5/15R-b
6/15R-b
7/15R-b R-b
8/15R-b
9/15R-b
10/15R-b
11/15
12/15R-b
13/15R-b
14/15
15/15R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 00/15] net/mlx5e: Extend XDP multi-buffer capabilities

Hi,

This series extends the XDP multi-buffer support in the mlx5e driver.

Patchset breakdown:
- Infrastructural changes and preparations.
- Add XDP multi-buffer support for XDP redirect-in.
- Use TX MPWQE (multi-packet WQE) HW feature for non-linear single-segmented XDP frames.
- Add XDP multi-buffer support for striding RQ.

In Striding RQ, we overcome the lack of headroom and tailroom between the RQ strides by allocating a side page per packet and using it for the xdp_buff descriptor. We structure the xdp_buff so that it contains nothing in the linear part, and the whole packet resides in the fragments.

Performance highlight:

Packet rate test, 64 bytes, 32 channels, MTU 9000 bytes.
CPU: Intel(R) Xeon(R) Platinum 8380 CPU @ 2.30GHz.
NIC: ConnectX-6 Dx, at 100 Gbps.

+----------+-------------+-------------+---------+
| Test     | Legacy RQ   | Striding RQ | Speedup |
+----------+-------------+-------------+---------+
| XDP_DROP | 101,615,544 | 117,191,020 | +15%    |
+----------+-------------+-------------+---------+
| XDP_TX   |  95,608,169 | 117,043,422 | +22%    |
+----------+-------------+-------------+---------+

Series generated against net commit:
e61caf04b9f8 Merge branch 'page_pool-allow-caching-from-safely-localized-napi'

I'm submitting this directly as Saeed is traveling.

Regards,
Tariq

Tariq Toukan (15):
net/mlx5e: Move XDP struct and enum to XDP header net/mlx5e: Move struct mlx5e_xmit_data to datapath header net/mlx5e: Introduce extended version for mlx5e_xmit_data net/mlx5e: XDP, Remove doubtful unlikely calls
net/mlx5e: XDP, Use multiple single-entry objects in xdpi_fifo net/mlx5e: XDP, Add support for multi-buffer XDP redirect-in net/mlx5e: XDP, Improve Striding RQ check with XDP net/mlx5e: XDP, Let XDP checker function get the params as input net/mlx5e: XDP, Consider large muti-buffer packets in Striding RQ
params calculations
net/mlx5e: XDP, Remove un-established assumptions on XDP buffer net/mlx5e: XDP, Allow non-linear single-segment frames in XDP TX MPWQE net/mlx5e: RX, Take shared info fragment addition into a function net/mlx5e: RX, Generalize mlx5e_fill_mxbuf()
net/mlx5e: RX, Prepare non-linear striding RQ for XDP multi-buffer
support
net/mlx5e: RX, Add XDP multi-buffer support in Striding RQ

 drivers/net/ethernet/mellanox/mlx5/core/en.h  |  46 +--
 .../ethernet/mellanox/mlx5/core/en/params.c   |  32 +-
 .../ethernet/mellanox/mlx5/core/en/params.h   |   3 +
 .../net/ethernet/mellanox/mlx5/core/en/txrx.h |  13 +
 .../net/ethernet/mellanox/mlx5/core/en/xdp.c  | 305 +++++++++++++-----
 .../net/ethernet/mellanox/mlx5/core/en/xdp.h  |  55 +++-
 .../ethernet/mellanox/mlx5/core/en/xsk/tx.c   |  12 +-
 .../net/ethernet/mellanox/mlx5/core/en_main.c |  92 +++---
 .../net/ethernet/mellanox/mlx5/core/en_rx.c   | 215 +++++++++---
 9 files changed, 519 insertions(+), 254 deletions(-)
Signature · 1 line
2.34.1