net/mlx5e: Extend XDP multi-buffer capabilities
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest15 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | net/mlx5e: Move XDP struct and enum to XDP headerdrivers/ drivers/ | +35 | 0 replies | |
| 2/15 | net/mlx5e: Move struct mlx5e_xmit_data to datapath headerdrivers/ drivers/ | +7 | 0 replies | |
| 3/15 | net/mlx5e: Introduce extended version for mlx5e_xmit_datadrivers/ drivers/ drivers/ +2 more | +44 | 0 replies | |
| 4/15 | net/mlx5e: XDP, Remove doubtful unlikely callsdrivers/ | +5 | 0 replies | |
| 5/15 | net/mlx5e: XDP, Use multiple single-entry objects in xdpi_fifodrivers/ drivers/ drivers/ +2 more | +101 | 0 replies | |
| 6/15 | net/mlx5e: XDP, Add support for multi-buffer XDP redirect-indrivers/ drivers/ drivers/ | +75 | 0 replies | |
| 7/15 | net/mlx5e: XDP, Improve Striding RQ check with XDPdrivers/ | +9 | 0 replies | |
| 8/15 | net/mlx5e: XDP, Let XDP checker function get the params as inputdrivers/ | +8 | 0 replies | |
| 9/15 | net/mlx5e: XDP, Consider large muti-buffer packets in Striding RQ params calculationsdrivers/ | +7 | 0 replies | |
| 10/15 | net/mlx5e: XDP, Remove un-established assumptions on XDP bufferdrivers/ drivers/ | +22 | 0 replies | |
| 11/15 | net/mlx5e: XDP, Allow non-linear single-segment frames in XDP TX MPWQEdrivers/ | +26 | 0 replies | |
| 12/15 | net/mlx5e: RX, Take shared info fragment addition into a functiondrivers/ | +31 | 0 replies | |
| 13/15 | net/mlx5e: RX, Generalize mlx5e_fill_mxbuf()drivers/ | +8 | 0 replies | |
| 14/15 | net/mlx5e: RX, Prepare non-linear striding RQ for XDP multi-buffer supportdrivers/ | +47 | 0 replies | |
| 15/15 | net/mlx5e: RX, Add XDP multi-buffer support in Striding RQdrivers/ drivers/ drivers/ +2 more | +138 | 0 replies |
Reviews trailers per patch
12 of 15 patches have a Reviewed-by or Acked-by.
| Patch | Saeed Mahameed | Gal Pressman |
|---|---|---|
| 1/15 | R-b | |
| 2/15 | R-b | |
| 3/15 | ||
| 4/15 | R-b | |
| 5/15 | R-b | |
| 6/15 | R-b | |
| 7/15 | R-b | R-b |
| 8/15 | R-b | |
| 9/15 | R-b | |
| 10/15 | R-b | |
| 11/15 | ||
| 12/15 | R-b | |
| 13/15 | R-b | |
| 14/15 | ||
| 15/15 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next 00/15] net/mlx5e: Extend XDP multi-buffer capabilities
Hi,
This series extends the XDP multi-buffer support in the mlx5e driver.
Patchset breakdown:
- Infrastructural changes and preparations.
- Add XDP multi-buffer support for XDP redirect-in.
- Use TX MPWQE (multi-packet WQE) HW feature for non-linear single-segmented XDP frames.
- Add XDP multi-buffer support for striding RQ.
In Striding RQ, we overcome the lack of headroom and tailroom between the RQ strides by allocating a side page per packet and using it for the xdp_buff descriptor. We structure the xdp_buff so that it contains nothing in the linear part, and the whole packet resides in the fragments.
Performance highlight:
Packet rate test, 64 bytes, 32 channels, MTU 9000 bytes.
CPU: Intel(R) Xeon(R) Platinum 8380 CPU @ 2.30GHz.
NIC: ConnectX-6 Dx, at 100 Gbps.
+----------+-------------+-------------+---------+ | Test | Legacy RQ | Striding RQ | Speedup | +----------+-------------+-------------+---------+ | XDP_DROP | 101,615,544 | 117,191,020 | +15% | +----------+-------------+-------------+---------+ | XDP_TX | 95,608,169 | 117,043,422 | +22% | +----------+-------------+-------------+---------+
Series generated against net commit:e61caf04b9f8 Merge branch 'page_pool-allow-caching-from-safely-localized-napi'
I'm submitting this directly as Saeed is traveling.
Regards,
Tariq
Tariq Toukan (15):
net/mlx5e: Move XDP struct and enum to XDP header net/mlx5e: Move struct mlx5e_xmit_data to datapath header net/mlx5e: Introduce extended version for mlx5e_xmit_data net/mlx5e: XDP, Remove doubtful unlikely calls
net/mlx5e: XDP, Use multiple single-entry objects in xdpi_fifo net/mlx5e: XDP, Add support for multi-buffer XDP redirect-in net/mlx5e: XDP, Improve Striding RQ check with XDP net/mlx5e: XDP, Let XDP checker function get the params as input net/mlx5e: XDP, Consider large muti-buffer packets in Striding RQ
params calculations
net/mlx5e: XDP, Remove un-established assumptions on XDP buffer net/mlx5e: XDP, Allow non-linear single-segment frames in XDP TX MPWQE net/mlx5e: RX, Take shared info fragment addition into a function net/mlx5e: RX, Generalize mlx5e_fill_mxbuf()
net/mlx5e: RX, Prepare non-linear striding RQ for XDP multi-buffer
support
net/mlx5e: RX, Add XDP multi-buffer support in Striding RQ
drivers/net/ethernet/mellanox/mlx5/core/en.h | 46 +-- .../ethernet/mellanox/mlx5/core/en/params.c | 32 +- .../ethernet/mellanox/mlx5/core/en/params.h | 3 + .../net/ethernet/mellanox/mlx5/core/en/txrx.h | 13 + .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 305 +++++++++++++----- .../net/ethernet/mellanox/mlx5/core/en/xdp.h | 55 +++- .../ethernet/mellanox/mlx5/core/en/xsk/tx.c | 12 +- .../net/ethernet/mellanox/mlx5/core/en_main.c | 92 +++--- .../net/ethernet/mellanox/mlx5/core/en_rx.c | 215 +++++++++--- 9 files changed, 519 insertions(+), 254 deletions(-)
Signature · 1 line
2.34.1