keepalive bugfixes
Status from this message: Thanks, applied for nvme-6.4.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest3 patches 2 repliesApplied
- v53 patches 3 repliesSuperseded
- v43 patches 1 replySuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 3 patches | 4 replies | Superseded | |
| v2 | 3 patches | 5 replies | Superseded | |
| v1 | 3 patches | 6 replies | Superseded |
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | nvme: double KA polling frequency to avoid KATO with TBKAS ondrivers/ | +17 | 0 replies | |
| 2/3 | nvme: check IO start time when deciding to defer KAdrivers/ drivers/ | +14 | 1 reply | |
| 3/3 | nvme: improve handling of long keep alivesdrivers/ | +15 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Hannes Reinecke | Sagi Grimberg | Christoph Hellwig |
|---|---|---|---|
| 1/3 | R-b | R-b | R-b |
| 2/3 | R-b | R-b | R-b |
| 3/3 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v6 0/3] keepalive bugfixes
While reviewing the Linux KATO implementation in an attempt to better understand the current NVMe Keep Alive specification, we found a few issues in the host implementation that could contribute to spurious Keep Alive timeouts being detected by controllers.
Changes v5-v6 (https://lore.kernel.org/linux-nvme/[email protected]/):
- Patch 2: fix line length and extra empty line, add comment about
req->deadline - req->timeout
Changes v4-v5 (https://lore.kernel.org/linux-nvme/[email protected]/):
- Patch 2: revert changes to start_time; use req->deadline -
req->timeout instead
Changes v3-v4 (https://lore.kernel.org/linux-nvme/[email protected]/):
- Patch 1: fix style, improve readability, include helper from patch 3
- Patch 2: refactor to remove need for WRITE_ONCE/barriers
- Patch 3: fix comment style, move helper to patch 1
Changes v2-v3 (https://lore.kernel.org/linux-nvme/[email protected]/):
- Patch 3: add a warning log line for long keepalive RTT
Changes v1-v2 (https://lore.kernel.org/linux-nvme/[email protected]/):
- Patch 2: fix indentation, set start_time even when stats disabled
Uday Shankar (3):
nvme: double KA polling frequency to avoid KATO with TBKAS on
nvme: check IO start time when deciding to defer KA
nvme: improve handling of long keep alives
drivers/nvme/host/core.c | 48 +++++++++++++++++++++++++++++++++++++--- drivers/nvme/host/nvme.h | 1 + 2 files changed, 46 insertions(+), 3 deletions(-)
Signature · 1 line
2.25.1