Skip to content

keepalive bugfixes

Uday Shankar linux-nvme 6 versions – Applied

Status from this message: Thanks, applied for nvme-6.4.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 2 repliesApplied
  2. v53 patches 3 repliesSuperseded
  3. v43 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches4 repliesSuperseded
v23 patches5 repliesSuperseded
v13 patches6 repliesSuperseded

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/3nvme: double KA polling frequency to avoid KATO with TBKAS ondrivers/nvme/host/core.c+17 -10 replies
2/3nvme: check IO start time when deciding to defer KAdrivers/nvme/host/core.c drivers/nvme/host/nvme.h+14 -11 reply
3/3nvme: improve handling of long keep alivesdrivers/nvme/host/core.c+15 -10 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchHannes ReineckeSagi GrimbergChristoph Hellwig
1/3R-b R-b R-b
2/3R-b R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/3] keepalive bugfixes

While reviewing the Linux KATO implementation in an attempt to better understand the current NVMe Keep Alive specification, we found a few issues in the host implementation that could contribute to spurious Keep Alive timeouts being detected by controllers.

Changes v5-v6 (https://lore.kernel.org/linux-nvme/[email protected]/):
- Patch 2: fix line length and extra empty line, add comment about
req->deadline - req->timeout

Changes v4-v5 (https://lore.kernel.org/linux-nvme/[email protected]/):
- Patch 2: revert changes to start_time; use req->deadline -

           req->timeout instead

Changes v3-v4 (https://lore.kernel.org/linux-nvme/[email protected]/):
- Patch 1: fix style, improve readability, include helper from patch 3
- Patch 2: refactor to remove need for WRITE_ONCE/barriers
- Patch 3: fix comment style, move helper to patch 1

Changes v2-v3 (https://lore.kernel.org/linux-nvme/[email protected]/):
- Patch 3: add a warning log line for long keepalive RTT

Changes v1-v2 (https://lore.kernel.org/linux-nvme/[email protected]/):
- Patch 2: fix indentation, set start_time even when stats disabled

Uday Shankar (3):
nvme: double KA polling frequency to avoid KATO with TBKAS on
nvme: check IO start time when deciding to defer KA
nvme: improve handling of long keep alives

 drivers/nvme/host/core.c | 48 +++++++++++++++++++++++++++++++++++++---
 drivers/nvme/host/nvme.h |  1 +
 2 files changed, 46 insertions(+), 3 deletions(-)
Signature · 1 line
2.25.1