Skip to content

nvme testsuite runtime optimization

Daniel Wagner linux-block linux-nvme lkml 5 versions – Applied

Status from this message: I've applied this v4 series. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest11 patches 9 repliesApplied
  2. v312 patches 25 repliesSuperseded
  3. v2 posting 2/29 patches 34 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 posting 1/29 patches1 replySuperseded
v1 RFC1 patch9 repliesSuperseded

Changes in v4 from the cover letter

- renamed test
- updated commit messages
- fixed whitespace damage
- fixed ShellCheck reports
- dropped 'limit number of random jobs'
- fio runtime 'invinity' changed to 1d
- fixed typo and updated documentation
- added tags

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/11nvme/rc: Auto convert test device size infocommon/rc tests/nvme/035+28 -40 replies
2/11nvme{014/015}: Do not hard code device size for dd testtests/nvme/014 tests/nvme/015+18 -20 replies
3/11common/xfs: Make size argument optional for _xfs_run_fio_verify_iocommon/xfs tests/nvme/012 tests/nvme/013+15 -30 replies
4/11common/xfs: Limit fio size job to fit into xfs fscommon/xfs+3 -01 reply
5/11nvme{032,040}: Use runtime fio background jobstests/nvme/032 tests/nvme/040+9 -43 replies
6/11Documentation: Add info on nvme_trtypeDocumentation/running-tests.md+7 -00 replies
7/11nvme: Make test image size configurableDocumentation/running-tests.md tests/nvme/004 tests/nvme/005 +35 more+45 -390 replies
8/11nvme: Add minimal test image size requirementtests/nvme/012 tests/nvme/013 tests/nvme/045 +1 more+18 -10 replies
9/11nvme{045,047}: Calculate IO size for random fio jobstests/nvme/045 tests/nvme/047 tests/nvme/rc+17 -33 replies
10/11nvme{002,030}: Move discovery generation counter code to rctests/nvme/002 tests/nvme/002.out tests/nvme/030 +1 more+20 -30231 reply
11/11nvme{016,017}: Make the number iterations configurableDocumentation/running-tests.md tests/nvme/016 tests/nvme/017 +1 more+5 -20 replies

Reviews trailers per patch

10 of 11 patches have a Reviewed-by or Acked-by.

PatchHannes ReineckeChaitanya Kulkarni
1/11R-b R-b
2/11R-b R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b R-b
8/11R-b R-b
9/11
10/11R-b R-b
11/11R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH blktests v4 00/11] nvme testsuite runtime optimization

I've updated the series with the comments from the last round.

changes
v4:
- renamed test
- updated commit messages
- fixed whitespace damage
- fixed ShellCheck reports
- dropped 'limit number of random jobs'
- fio runtime 'invinity' changed to 1d
- fixed typo and updated documentation
- added tags

v3:
- 'nvme/rc' instead of 'nvme-rc' subject prefi x
- fixed spaces vs tabs indention
- nvme/014, nvme/015 dropped -1 in #block calculation
- common/xfs: use 'tail -1' instead 'awk'
- common/xfs: no need for printf for integer division
- nvme/035 limit disk size via nvme_img_size
- set defaults to previous values: nvme_img_size=1G, nvme_num_iter=1000
- nvme/032, nvme/040 let fio figure out image size
set timeout to infinity
cleanup fio
- add documentation for nvme_tr_type, nvme_img_size and nvme_num_iter
- limited nproc to 32 for num jobs for random fio job
- drop job size limit calculation
- drop nvme_num_iter from nvme/002
- limit xfs fio job size inside _xfs_run_fio_verify_io()
- added reviewed tags
- https://lore.kernel.org/linux-nvme/[email protected]/

v2:
- made image size configurable via nvme_img_size env
- make number of iteration configurable via nvme_num_iter
- do not hard code test values
- calculate job size
- use runtime for fio background jobs
- https://lore.kernel.org/linux-nvme/[email protected]/

v1:
- initial version
- https://lore.kernel.org/linux-nvme/[email protected]/

Daniel Wagner (11):
nvme/rc: Auto convert test device size info nvme{014/015}: Do not hard code device size for dd test common/xfs: Make size argument optional for _xfs_run_fio_verify_io common/xfs: Limit fio size job to fit into xfs fs nvme{032,040}: Use runtime fio background jobs
Documentation: Add info on nvme_trtype
nvme: Make test image size configurable
nvme: Add minimal test image size requirement nvme{045,047}: Calculate IO size for random fio jobs nvme{002,030}: Move discovery generation counter code to rc nvme{016,017}: Make the number iterations configurable

 Documentation/running-tests.md |   12 +
 common/rc                      |   30 +-
 common/xfs                     |   17 +-
 tests/nvme/002                 |    4 +-
 tests/nvme/002.out             | 3004 --------------------------------
 tests/nvme/004                 |    2 +-
 tests/nvme/005                 |    2 +-
 tests/nvme/006                 |    2 +-
 tests/nvme/007                 |    2 +-
 tests/nvme/008                 |    2 +-
 tests/nvme/009                 |    2 +-
 tests/nvme/010                 |    5 +-
 tests/nvme/011                 |    5 +-
 tests/nvme/012                 |    5 +-
 tests/nvme/013                 |    5 +-
 tests/nvme/014                 |   12 +-
 tests/nvme/015                 |   12 +-
 tests/nvme/016                 |    2 +-
 tests/nvme/017                 |    4 +-
 tests/nvme/018                 |    2 +-
 tests/nvme/019                 |    2 +-
 tests/nvme/020                 |    2 +-
 tests/nvme/021                 |    2 +-
 tests/nvme/022                 |    2 +-
 tests/nvme/023                 |    2 +-
 tests/nvme/024                 |    2 +-
 tests/nvme/025                 |    2 +-
 tests/nvme/026                 |    2 +-
 tests/nvme/027                 |    2 +-
 tests/nvme/028                 |    2 +-
 tests/nvme/029                 |    2 +-
 tests/nvme/030                 |   22 +-
 tests/nvme/031                 |    2 +-
 tests/nvme/032                 |    4 +-
 tests/nvme/034                 |    2 +-
 tests/nvme/035                 |    4 +-
 tests/nvme/040                 |   11 +-
 tests/nvme/041                 |    2 +-
 tests/nvme/042                 |    2 +-
 tests/nvme/043                 |    2 +-
 tests/nvme/044                 |    2 +-
 tests/nvme/045                 |    6 +-
 tests/nvme/047                 |    8 +-
 tests/nvme/048                 |    2 +-
 tests/nvme/rc                  |   40 +
 45 files changed, 183 insertions(+), 3079 deletions(-)
Signature · 1 line
2.40.0