bio: check return values of bio_add_page
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest22 patches 1 replyIn review
- v319 patches 5 repliesSuperseded
Changes to v3 from the cover letter
- Added __bio_add_folio and use it in iomap (Willy)
- Mark bio_add_folio must check (Willy)
- s/GFS/GFS2/ (Andreas)
Patches in v4 No applies recorded yet
Reviews trailers per patch
19 of 22 patches have a Reviewed-by or Acked-by.
| Patch | Damien Le Moal | Johannes Thumshirn | Song Liu | Dave Kleikamp | Andreas Gruenbacher | Sergey Senozhatsky |
|---|---|---|---|---|---|---|
| 1/22 | R-b | |||||
| 2/22 | R-b | |||||
| 3/22 | R-b | |||||
| 4/22 | R-b | |||||
| 5/22 | R-b | Signed-of_-by | A-b | |||
| 6/22 | R-b | A-b | ||||
| 7/22 | R-b | A-b | ||||
| 8/22 | R-b | |||||
| 9/22 | R-b | |||||
| 10/22 | R-b | A-b | ||||
| 11/22 | R-b | R-b | ||||
| 12/22 | A-b | |||||
| 13/22 | R-b | R-b | ||||
| 14/22 | R-b | |||||
| 15/22 | R-b | |||||
| 16/22 | R-b | A-b | ||||
| 17/22 | R-b | A-b | ||||
| 18/22 | R-b | |||||
| 19/22 | R-b | |||||
| 20/22 | ||||||
| 21/22 | ||||||
| 22/22 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.
Cover letter [PATCH v4 00/22] bio: check return values of bio_add_page
We have two functions for adding a page to a bio, __bio_add_page() which is used to add a single page to a freshly created bio and bio_add_page() which is used to add a page to an existing bio.
While __bio_add_page() is expected to succeed, bio_add_page() can fail.
This series converts the callers of bio_add_page() which can easily use __bio_add_page() to using it and checks the return of bio_add_page() for callers that don't work on a freshly created bio.
Lastly it marks bio_add_page() as __must_check so we don't have to go again and audit all callers.
NOTE: David already applied the two btrfs patches to his tree but I've left them in the series to make the build bot happy.
Changes to v3:
- Added __bio_add_folio and use it in iomap (Willy)
- Mark bio_add_folio must check (Willy)
- s/GFS/GFS2/ (Andreas)
Changes to v2:
- Removed 'wont fail' comments pointed out by Song
Changes to v1:
- Removed pointless comment pointed out by Willy
- Changed commit messages pointed out by Damien
- Colledted Damien's Reviews and Acks
Johannes Thumshirn (22):
swap: use __bio_add_page to add page to bio
drbd: use __bio_add_page to add page to bio
dm: dm-zoned: use __bio_add_page for adding single metadata page
fs: buffer: use __bio_add_page to add single page to bio
md: use __bio_add_page to add single page
md: raid5-log: use __bio_add_page to add single page
md: raid5: use __bio_add_page to add single page to new bio
btrfs: repair: use __bio_add_page for adding single page
btrfs: raid56: use __bio_add_page to add single page
jfs: logmgr: use __bio_add_page to add single page to bio
gfs2: use __bio_add_page for adding single page to bio
zonefs: use __bio_add_page for adding single page to bio
zram: use __bio_add_page for adding single page to bio
floppy: use __bio_add_page for adding single page to bio
md: check for failure when adding pages in alloc_behind_master_bio
md: raid1: use __bio_add_page for adding single page to bio
md: raid1: check if adding pages to resync bio fails
dm-crypt: check if adding pages to clone bio fails
block: mark bio_add_page as __must_check
block: add __bio_add_folio
fs: iomap: use __bio_add_folio where possible
block: mark bio_add_folio as __must_check
block/bio.c | 8 ++++++++ drivers/block/drbd/drbd_bitmap.c | 4 +--- drivers/block/floppy.c | 2 +- drivers/block/zram/zram_drv.c | 2 +- drivers/md/dm-crypt.c | 9 ++++++++- drivers/md/dm-zoned-metadata.c | 6 +++--- drivers/md/md.c | 4 ++-- drivers/md/raid1-10.c | 11 ++++++----- drivers/md/raid1.c | 7 +++++-- drivers/md/raid10.c | 20 ++++++++++---------- drivers/md/raid5-cache.c | 2 +- drivers/md/raid5-ppl.c | 4 ++-- fs/btrfs/bio.c | 2 +- fs/btrfs/raid56.c | 2 +- fs/buffer.c | 2 +- fs/gfs2/ops_fstype.c | 2 +- fs/iomap/buffered-io.c | 6 +++--- fs/jfs/jfs_logmgr.c | 4 ++-- fs/zonefs/super.c | 2 +- include/linux/bio.h | 5 +++-- mm/page_io.c | 8 ++++---- 21 files changed, 65 insertions(+), 47 deletions(-)
base-commit: af67688dca57999fd848f051eeea1d375ba546b2
Signature · 1 line
2.39.2