Skip to content

bio: check return values of bio_add_page

Johannes Thumshirn cluster-devel dm-devel linux-block linux-btrfs linux-fsdevel linux-mm linux-raid 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest22 patches 1 replyIn review
  2. v319 patches 5 repliesSuperseded

Changes to v3 from the cover letter

- Added __bio_add_folio and use it in iomap (Willy)
- Mark bio_add_folio must check (Willy)
- s/GFS/GFS2/ (Andreas)

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22swap: use __bio_add_page to add page to biomm/page_io.c+4 -40 replies
2/22drbd: use __bio_add_page to add page to biodrivers/block/drbd/drbd_bitmap.c+1 -30 replies
3/22dm: dm-zoned: use __bio_add_page for adding single metadata pagedrivers/md/dm-zoned-metadata.c+3 -30 replies
4/22fs: buffer: use __bio_add_page to add single page to biofs/buffer.c+1 -10 replies
5/22md: use __bio_add_page to add single pagedrivers/md/md.c+2 -20 replies
6/22md: raid5-log: use __bio_add_page to add single pagedrivers/md/raid5-cache.c+1 -10 replies
7/22md: raid5: use __bio_add_page to add single page to new biodrivers/md/raid5-ppl.c+2 -20 replies
8/22btrfs: repair: use __bio_add_page for adding single pagefs/btrfs/bio.c+1 -10 replies
9/22btrfs: raid56: use __bio_add_page to add single pagefs/btrfs/raid56.c+1 -10 replies
10/22jfs: logmgr: use __bio_add_page to add single page to biofs/jfs/jfs_logmgr.c+2 -20 replies
11/22gfs2: use __bio_add_page for adding single page to biofs/gfs2/ops_fstype.c+1 -10 replies
12/22zonefs: use __bio_add_page for adding single page to biofs/zonefs/super.c+1 -10 replies
13/22zram: use __bio_add_page for adding single page to biodrivers/block/zram/zram_drv.c+1 -11 reply
14/22floppy: use __bio_add_page for adding single page to biodrivers/block/floppy.c+1 -10 replies
15/22md: check for failure when adding pages in alloc_behind_master_biodrivers/md/raid1.c+4 -10 replies
16/22md: raid1: use __bio_add_page for adding single page to biodrivers/md/raid1.c+1 -10 replies
17/22md: raid1: check if adding pages to resync bio failsdrivers/md/raid1-10.c drivers/md/raid10.c+16 -150 replies
18/22dm-crypt: check if adding pages to clone bio failsdrivers/md/dm-crypt.c+8 -10 replies
19/22block: mark bio_add_page as __must_checkinclude/linux/bio.h+1 -10 replies
20/22block: add __bio_add_folioblock/bio.c include/linux/bio.h+9 -00 replies
21/22fs: iomap: use __bio_add_folio where possiblefs/iomap/buffered-io.c+3 -30 replies
22/22block: mark bio_add_folio as __must_checkinclude/linux/bio.h+1 -10 replies

Reviews trailers per patch

19 of 22 patches have a Reviewed-by or Acked-by.

PatchDamien Le MoalJohannes ThumshirnSong LiuDave KleikampAndreas GruenbacherSergey Senozhatsky
1/22R-b
2/22R-b
3/22R-b
4/22R-b
5/22R-b Signed-of_-by A-b
6/22R-b A-b
7/22R-b A-b
8/22R-b
9/22R-b
10/22R-b A-b
11/22R-b R-b
12/22A-b
13/22R-b R-b
14/22R-b
15/22R-b
16/22R-b A-b
17/22R-b A-b
18/22R-b
19/22R-b
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/22] bio: check return values of bio_add_page

We have two functions for adding a page to a bio, __bio_add_page() which is used to add a single page to a freshly created bio and bio_add_page() which is used to add a page to an existing bio.

While __bio_add_page() is expected to succeed, bio_add_page() can fail.

This series converts the callers of bio_add_page() which can easily use __bio_add_page() to using it and checks the return of bio_add_page() for callers that don't work on a freshly created bio.

Lastly it marks bio_add_page() as __must_check so we don't have to go again and audit all callers.

NOTE: David already applied the two btrfs patches to his tree but I've left them in the series to make the build bot happy.

Changes to v3:
- Added __bio_add_folio and use it in iomap (Willy)
- Mark bio_add_folio must check (Willy)
- s/GFS/GFS2/ (Andreas)

Changes to v2:
- Removed 'wont fail' comments pointed out by Song

Changes to v1:
- Removed pointless comment pointed out by Willy
- Changed commit messages pointed out by Damien
- Colledted Damien's Reviews and Acks

Johannes Thumshirn (22):
swap: use __bio_add_page to add page to bio
drbd: use __bio_add_page to add page to bio
dm: dm-zoned: use __bio_add_page for adding single metadata page
fs: buffer: use __bio_add_page to add single page to bio
md: use __bio_add_page to add single page
md: raid5-log: use __bio_add_page to add single page
md: raid5: use __bio_add_page to add single page to new bio
btrfs: repair: use __bio_add_page for adding single page
btrfs: raid56: use __bio_add_page to add single page
jfs: logmgr: use __bio_add_page to add single page to bio
gfs2: use __bio_add_page for adding single page to bio
zonefs: use __bio_add_page for adding single page to bio
zram: use __bio_add_page for adding single page to bio
floppy: use __bio_add_page for adding single page to bio
md: check for failure when adding pages in alloc_behind_master_bio
md: raid1: use __bio_add_page for adding single page to bio
md: raid1: check if adding pages to resync bio fails
dm-crypt: check if adding pages to clone bio fails
block: mark bio_add_page as __must_check
block: add __bio_add_folio
fs: iomap: use __bio_add_folio where possible
block: mark bio_add_folio as __must_check

 block/bio.c                      |  8 ++++++++
 drivers/block/drbd/drbd_bitmap.c |  4 +---
 drivers/block/floppy.c           |  2 +-
 drivers/block/zram/zram_drv.c    |  2 +-
 drivers/md/dm-crypt.c            |  9 ++++++++-
 drivers/md/dm-zoned-metadata.c   |  6 +++---
 drivers/md/md.c                  |  4 ++--
 drivers/md/raid1-10.c            | 11 ++++++-----
 drivers/md/raid1.c               |  7 +++++--
 drivers/md/raid10.c              | 20 ++++++++++----------
 drivers/md/raid5-cache.c         |  2 +-
 drivers/md/raid5-ppl.c           |  4 ++--
 fs/btrfs/bio.c                   |  2 +-
 fs/btrfs/raid56.c                |  2 +-
 fs/buffer.c                      |  2 +-
 fs/gfs2/ops_fstype.c             |  2 +-
 fs/iomap/buffered-io.c           |  6 +++---
 fs/jfs/jfs_logmgr.c              |  4 ++--
 fs/zonefs/super.c                |  2 +-
 include/linux/bio.h              |  5 +++--
 mm/page_io.c                     |  8 ++++----
 21 files changed, 65 insertions(+), 47 deletions(-)

base-commit: af67688dca57999fd848f051eeea1d375ba546b2

Signature · 1 line
2.39.2