Skip to content

RFC: Add new device configuration infrastructure to

Stuart Summers intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/xe: Refactor early device initdrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device.h drivers/gpu/drm/xe/xe_pci.c+20 -90 replies
2/4drm/xe: Refactor debugfs into an early and late partdrivers/gpu/drm/xe/xe_debugfs.c drivers/gpu/drm/xe/xe_debugfs.h drivers/gpu/drm/xe/xe_pci.c+13 -40 replies
3/4drm/xe: Add new device configuration debugfs infrastructuredrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_debugfs_params.c drivers/gpu/drm/xe/xe_debugfs_params.h +4 more+418 -02 replies
4/4drm/xe: Migrate module parameters to new debugfs structuredrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_display.c drivers/gpu/drm/xe/xe_guc_log.c +4 more+11 -280 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Intel-xe] [PATCH 0/4] RFC: Add new device configuration infrastructure to

This is attempting to take the best parts of i915 module parameters (minus the actual module parameters) and add to xe to allow for better debuggability and configuration in order to help isolate problems on a per-device level instead of global module parameters.

Note that I did review a few options here: configfs (not generally used by the drm stack), module parameters (we have some negative history here), sysfs (not the right approach given the focus on user interface here). Debugfs is used in various drm drivers to configure various device characteristics. The infrastructure being presented here has at a high level been present in the i915 driver for some years now, so provides a good starting point for quick debug additions without exposing users to some of the challenges faced with module parameters in the past.

Stuart Summers (4):
drm/xe: Refactor early device init
drm/xe: Refactor debugfs into an early and late part drm/xe: Add new device configuration debugfs infrastructure drm/xe: Migrate module parameters to new debugfs structure

 drivers/gpu/drm/xe/Makefile            |   1 +
 drivers/gpu/drm/xe/xe_debugfs.c        |  14 +-
 drivers/gpu/drm/xe/xe_debugfs.h        |   1 +
 drivers/gpu/drm/xe/xe_debugfs_params.c | 235 +++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_debugfs_params.h |  14 ++
 drivers/gpu/drm/xe/xe_device.c         |  23 ++-
 drivers/gpu/drm/xe/xe_device.h         |   4 +-
 drivers/gpu/drm/xe/xe_device_types.h   |   4 +
 drivers/gpu/drm/xe/xe_display.c        |   3 +-
 drivers/gpu/drm/xe/xe_guc_log.c        |   2 +-
 drivers/gpu/drm/xe/xe_mmio.c           |   4 +-
 drivers/gpu/drm/xe/xe_module.c         |  16 --
 drivers/gpu/drm/xe/xe_module.h         |   5 -
 drivers/gpu/drm/xe/xe_params.c         | 118 +++++++++++++
 drivers/gpu/drm/xe/xe_params.h         |  43 +++++
 drivers/gpu/drm/xe/xe_pci.c            |  14 +-
 16 files changed, 461 insertions(+), 40 deletions(-)
 create mode 100644 drivers/gpu/drm/xe/xe_debugfs_params.c
 create mode 100644 drivers/gpu/drm/xe/xe_debugfs_params.h
 create mode 100644 drivers/gpu/drm/xe/xe_params.c
 create mode 100644 drivers/gpu/drm/xe/xe_params.h
Signature · 1 line
2.38.1.143.g1fc3c0ad40