Skip to content

leds: trigger: netdev: fixup preparation for LEDs hw control

Christian Marangi linux-leds lkml stable 1 version Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 10 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5leds: trigger: netdev: recheck NETDEV_LED_MODE_LINKUP on dev renamedrivers/leds/trigger/ledtrig-netdev.c+3 -02 replies
2/5leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from modedrivers/leds/trigger/ledtrig-netdev.c+8 -112 replies
3/5leds: trigger: netdev: rename add namespace to netdev trigger enum modesdrivers/leds/trigger/ledtrig-netdev.c+25 -332 replies
4/5leds: trigger: netdev: convert device attr to macrodrivers/leds/trigger/ledtrig-netdev.c+16 -412 replies
5/5leds: trigger: netdev: use mutex instead of spinlocksdrivers/leds/trigger/ledtrig-netdev.c+9 -92 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchAndrew Lunn
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] leds: trigger: netdev: fixup preparation for LEDs hw control

This is a continue of [1]. It was decided to take a more gradual approach to implement LEDs support for switch and phy starting with basic support and then implementing the hw control part when we have all the prereq done.

This is a small series in preparation for a bigger change adding support for LEDs hw control.

Some minor fixup and improvements are required to add support for LEDs hw control for the netdev trigger.

The main fixes are switching to mutex from spinlocks and adding namespace to netdev trigger enum modes. These will be exposed in the future in the generic linux include folder so LEDs driver may supports these specific modes.

While working on htis it was also discovered a bug addressed in the first patch of this series.

Changes from the old v8 series:
- Reword some commits and add more info on why the changes is needed
- Add fixup patch on dev rename

Christian Marangi (5):
leds: trigger: netdev: recheck NETDEV_LED_MODE_LINKUP on dev rename
leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode
leds: trigger: netdev: rename add namespace to netdev trigger enum
modes
leds: trigger: netdev: convert device attr to macro
leds: trigger: netdev: use mutex instead of spinlocks

 drivers/leds/trigger/ledtrig-netdev.c | 151 ++++++++++----------------
 1 file changed, 59 insertions(+), 92 deletions(-)
Signature · 1 line
2.39.2