Skip to content

KVM: s390: pv: fix asynchronous teardown for small VMs

Claudio Imbrenda kvm linux-s390 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest1 patch 2 repliesIn review
  2. v11 patch 6 repliesSuperseded

Changes in v2 from the cover letter

After talking with Marc, I decided to throw away most of the patch and instead simply refuse to prepare for asynchronous teardown if the VM has a segment type ASCE.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1KVM: s390: pv: fix asynchronous teardown for small VMsarch/s390/kvm/pv.c arch/s390/mm/gmap.c+12 -02 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchJanosch FrankMarc Hartmayer
1/1R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/1] KVM: s390: pv: fix asynchronous teardown for small VMs

On machines without the Destroy Secure Configuration Fast UVC, the topmost level of page tables is set aside and freed asynchronously as last step of the asynchronous teardown.

Each gmap has a host_to_guest radix tree mapping host (userspace) addresses (with 1M granularity) to gmap segment table entries (pmds).

If a guest is smaller than 2GB, the topmost level of page tables is the segment table (i.e. there are only 2 levels). Replacing it means that the pointers in the host_to_guest mapping would become stale and cause all kinds of nasty issues.

This patch fixes the issue by disallowing asynchronous teardown for guests with only 2 levels of page tables. Userspace should (and already does) try using the normal destroy if the asynchronous one fails.

Update s390_replace_asce so it refuses to replace segment type ASCEs.

v1->v2:
After talking with Marc, I decided to throw away most of the patch and instead simply refuse to prepare for asynchronous teardown if the VM has a segment type ASCE.

Claudio Imbrenda (1):
KVM: s390: pv: fix asynchronous teardown for small VMs

 arch/s390/kvm/pv.c  | 5 +++++
 arch/s390/mm/gmap.c | 7 +++++++
 2 files changed, 12 insertions(+)
Signature · 1 line
2.40.0