Skip to content

hw/cxl: CDAT file handling fixes.

Jonathan Cameron via qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hw/cxl: cdat: Fix open file not closed in ct3_load_cdat()hw/cxl/cxl-cdat.c+8 -211 reply
2/2hw/cxl: cdat: Fix failure to free buffer in erorr pathshw/cxl/cxl-cdat.c hw/mem/cxl_type3.c hw/pci-bridge/cxl_upstream.c+25 -151 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchFan Ni
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] hw/cxl: CDAT file handling fixes.

I've picked up Hao Zeng's v5 and added a patch to deal with the issues that Peter pointed out in this area.

On error, the CDAT file handling left resource dangling and didn't cleanly exit from calling functions. Hao Zeng dealt with closing the file. The second patch deals with the buffer allocation and ensuring a clean exit at the two callers.

Hao Zeng (1):
hw/cxl: cdat: Fix open file not closed in ct3_load_cdat()

Jonathan Cameron (1):
hw/cxl: cdat: Fix failure to free buffer in erorr paths

 hw/cxl/cxl-cdat.c            | 60 +++++++++++++++---------------------
 hw/mem/cxl_type3.c           |  4 +++
 hw/pci-bridge/cxl_upstream.c |  3 ++
 3 files changed, 32 insertions(+), 35 deletions(-)
Signature · 1 line
2.37.2