Skip to content

Netfilter/IPVS updates for net-next

Pablo Neira Ayuso netdev netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20netfilter: nft_exthdr: add boolean DCCP option matchinginclude/uapi/linux/netfilter/nf_tables.h net/netfilter/nft_exthdr.c+107 -00 replies
2/20netfilter: nf_tables: merge nft_rules_old structure and end of ruleblob markernet/netfilter/nf_tables_api.c+27 -280 replies
3/20netfilter: nf_tables: don't store address of last rule on jumpnet/netfilter/nf_tables_core.c+2 -60 replies
4/20netfilter: nf_tables: don't store chain address on jumpinclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_api.c net/netfilter/nf_tables_core.c +1 more+44 -280 replies
5/20netfilter: nf_tables: don't write table validation state without mutexinclude/linux/netfilter/nfnetlink.h net/netfilter/nf_tables_api.c net/netfilter/nfnetlink.c+2 -90 replies
6/20netfilter: nf_tables: make validation state per tableinclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_api.c+20 -210 replies
7/20netfilter: nf_tables: remove unneeded conditionalnet/netfilter/nf_tables_core.c+2 -40 replies
8/20netfilter: nf_tables: do not store pktinfo in traceinfo structureinclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_core.c net/netfilter/nf_tables_trace.c+16 -150 replies
9/20netfilter: nf_tables: do not store verdict in traceinfo structureinclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_core.c net/netfilter/nf_tables_trace.c+20 -190 replies
10/20netfilter: nf_tables: do not store rule in traceinfo structureinclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_core.c net/netfilter/nf_tables_trace.c+16 -160 replies
11/20ipvs: Update width of source for ip_vs_sync_conn_optionsinclude/net/ip_vs.h net/netfilter/ipvs/ip_vs_sync.c+5 -30 replies
12/20ipvs: Consistently use array_size() in ip_vs_conn_init()net/netfilter/ipvs/ip_vs_conn.c+6 -60 replies
13/20ipvs: Remove {Enter,Leave}Functioninclude/net/ip_vs.h net/netfilter/ipvs/ip_vs_core.c net/netfilter/ipvs/ip_vs_ctl.c +2 more+9 -1120 replies
14/20ipvs: Correct spelling in commentsinclude/net/ip_vs.h+3 -30 replies
15/20netfilter: nf_tables: extended netlink error reporting for netdevicenet/netfilter/nf_tables_api.c+24 -140 replies
16/20netfilter: nf_tables: do not send complete notification of deletionsnet/netfilter/nf_tables_api.c+51 -190 replies
17/20netfilter: nf_tables: rename function to destroy hook listnet/netfilter/nf_tables_api.c+4 -40 replies
18/20netfilter: nf_tables: support for adding new devices to an existing netdev chaininclude/net/netfilter/nf_tables.h net/netfilter/nf_tables_api.c+142 -810 replies
19/20netfilter: nf_tables: support for deleting devices in an existing netdev chainnet/netfilter/nf_tables_api.c+88 -110 replies
20/20netfilter: nf_tables: allow to create netdev chain without devicenet/netfilter/nf_tables_api.c+11 -120 replies

Reviews trailers per patch

4 of 20 patches have a Reviewed-by or Acked-by.

PatchHoratiu Vultur
1/20
2/20
3/20
4/20
5/20
6/20
7/20
8/20
9/20
10/20
11/20R-b
12/20R-b
13/20R-b
14/20R-b
15/20
16/20
17/20
18/20
19/20
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 00/20] Netfilter/IPVS updates for net-next

Hi,

The following patchset contains Netfilter updates for net-next:

1) DCCP option matching support, from Jeremy Sowden.

2) Reduce jumpstack footprint: Stash chain in last rule marker in blob for tracing. Remove last rule and chain from jumpstack. From Florian Westphal.

3) nf_tables validates all tables before committing the new rules. Unfortunately, this has two drawbacks:

- Since addition of the transaction mutex pernet state gets written to outside of the locked section from the cleanup callback, this is wrong so do this cleanup directly after table has passed all checks.

- Revalidate tables that saw no changes. This can be avoided by keeping the validation state per table, not per netns.

From Florian Westphal.

4) Get rid of a few redundant pointers in the traceinfo structure. The three removed pointers are used in the expression evaluation loop, so gcc keeps them in registers. Passing them to the (inlined) helpers thus doesn't increase nft_do_chain text size, while stack is reduced by another 24 bytes on 64bit arches. From Florian Westphal.

5) IPVS cleanups in several ways without implementing any functional changes, aside from removing some debugging output:

- Update width of source for ip_vs_sync_conn_options
The operation is safe, use an annotation to describe it properly.

- Consistently use array_size() in ip_vs_conn_init() It seems better to use helpers consistently.

- Remove {Enter,Leave}Function. These seem to be well past their use-by date.

- Correct spelling in comments.

From Simon Horman.

6) Extended netlink error report for netdevice in flowtables and netdev/chains. Allow for incrementally add/delete devices to netdev basechain. Allow to create netdev chain without device.

Please, pull these changes from:

git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.git

Thanks.

----------------------------------------------------------------

The following changes since commit ca288965801572fe41386560d4e6c5cc0e5cc56d:

Merge tag 'wireless-next-2023-04-21' of git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next (2023-04-21 07:35:51 -0700)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.git nf-next-23-04-22

for you to fetch changes up to c7ce03c47ae836cad7d95fc08dc564452fe9b6e3:

netfilter: nf_tables: allow to create netdev chain without device (2023-04-22 00:23:35 +0200)

----------------------------------------------------------------
netfilter pull request 23-04-22

----------------------------------------------------------------
Florian Westphal (9):
netfilter: nf_tables: merge nft_rules_old structure and end of ruleblob marker
netfilter: nf_tables: don't store address of last rule on jump
netfilter: nf_tables: don't store chain address on jump
netfilter: nf_tables: don't write table validation state without mutex
netfilter: nf_tables: make validation state per table
netfilter: nf_tables: remove unneeded conditional
netfilter: nf_tables: do not store pktinfo in traceinfo structure
netfilter: nf_tables: do not store verdict in traceinfo structure
netfilter: nf_tables: do not store rule in traceinfo structure

Jeremy Sowden (1):
netfilter: nft_exthdr: add boolean DCCP option matching

Pablo Neira Ayuso (6):
netfilter: nf_tables: extended netlink error reporting for netdevice
netfilter: nf_tables: do not send complete notification of deletions
netfilter: nf_tables: rename function to destroy hook list
netfilter: nf_tables: support for adding new devices to an existing netdev chain
netfilter: nf_tables: support for deleting devices in an existing netdev chain
netfilter: nf_tables: allow to create netdev chain without device

Simon Horman (4):
ipvs: Update width of source for ip_vs_sync_conn_options
ipvs: Consistently use array_size() in ip_vs_conn_init()
ipvs: Remove {Enter,Leave}Function
ipvs: Correct spelling in comments

 include/linux/netfilter/nfnetlink.h      |   1 -
 include/net/ip_vs.h                      |  32 +-
 include/net/netfilter/nf_tables.h        |  35 +-
 include/uapi/linux/netfilter/nf_tables.h |   2 +
 net/netfilter/ipvs/ip_vs_conn.c          |  12 +-
 net/netfilter/ipvs/ip_vs_core.c          |   8 -
 net/netfilter/ipvs/ip_vs_ctl.c           |  26 +-
 net/netfilter/ipvs/ip_vs_sync.c          |   7 +-
 net/netfilter/ipvs/ip_vs_xmit.c          |  62 +---
 net/netfilter/nf_tables_api.c            | 539 ++++++++++++++++++++-----------
 net/netfilter/nf_tables_core.c           |  59 ++--
 net/netfilter/nf_tables_trace.c          |  62 ++--
 net/netfilter/nfnetlink.c                |   2 -
 net/netfilter/nft_exthdr.c               | 105 ++++++
 14 files changed, 570 insertions(+), 382 deletions(-)