Skip to content

perf: cs-etm: Fixes around timestamped and timeless decoding

James Clark linux-arm-kernel linux-perf-users lkml 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 13 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7perf: cs-etm: Fix timeless decode mode detectiontools/perf/util/cs-etm.c+18 -122 replies
2/7perf tools: Add util function for overriding user set config valuestools/perf/arch/arm64/util/arm-spe.c tools/perf/arch/x86/util/intel-pt.c tools/perf/util/evsel.c +1 more+36 -444 replies
3/7perf: cs-etm: Don't test full_auxtrace because it's always settools/perf/arch/arm/util/cs-etm.c+25 -310 replies
4/7perf: cs-etm: Validate options after applying themtools/perf/arch/arm/util/cs-etm.c+68 -845 replies
5/7perf: cs-etm: Allow user to override timestamp and contextid settingstools/perf/arch/arm/util/cs-etm.c tools/perf/arch/arm/util/pmu.c tools/perf/util/cs-etm.h+27 -60 replies
6/7perf: cs-etm: Use bool type for boolean valuestools/perf/util/cs-etm-decoder/cs-etm-decoder.h tools/perf/util/cs-etm.c tools/perf/util/cs-etm.h+10 -100 replies
7/7perf: cs-etm: Add separate decode paths for timeless and per-thread modestools/perf/tests/shell/test_arm_coresight.sh tools/perf/util/cs-etm.c+148 -380 replies

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAdrian HunterDenis NikitinLeo Yan
SeriesA-b
1/7
2/7A-b
3/7
4/7R-b
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/7] perf: cs-etm: Fixes around timestamped and timeless decoding

The first commit contains a fix for a recently introduced regression, but was always a shortcoming in the Coresight code anyway.

The following commits are a tidyup in preparation for the last commit, which is a fairly major change to the decode logic that's also indirectly related to the regression so I thought it would be good time to fix that now.

Applies to perf/core (9be6ab181b7b)

James Clark (7):
perf: cs-etm: Fix timeless decode mode detection
perf tools: Add util function for overriding user set config values
perf: cs-etm: Don't test full_auxtrace because it's always set
perf: cs-etm: Validate options after applying them
perf: cs-etm: Allow user to override timestamp and contextid settings
perf: cs-etm: Use bool type for boolean values
perf: cs-etm: Add separate decode paths for timeless and per-thread
modes

 tools/perf/arch/arm/util/cs-etm.c             | 223 +++++++++---------
 tools/perf/arch/arm/util/pmu.c                |   2 +
 tools/perf/arch/arm64/util/arm-spe.c          |  26 +-
 tools/perf/arch/x86/util/intel-pt.c           |  22 +-
 tools/perf/tests/shell/test_arm_coresight.sh  |  24 ++
 .../perf/util/cs-etm-decoder/cs-etm-decoder.h |   8 +-
 tools/perf/util/cs-etm.c                      | 200 +++++++++++-----
 tools/perf/util/cs-etm.h                      |   6 +-
 tools/perf/util/evsel.c                       |  29 +++
 tools/perf/util/evsel.h                       |   3 +
 10 files changed, 325 insertions(+), 218 deletions(-)
Signature · 1 line
2.34.1