Skip to content

RFC Deprecate the qemu-system-i386 binary

Thomas Huth qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3cpu: Add a way to detect 32-bit mode from argv0cpu.c include/hw/core/cpu.h softmmu/vl.c+24 -00 replies
2/3target/i386/cpu: Allow to limit the 64-bit binary to 32-bit mode onlytarget/i386/cpu.c target/i386/cpu.h target/i386/gdbstub.c+16 -240 replies
3/3docs/about/deprecated: Deprecate the qemu-system-i386 binarydocs/about/deprecated.rst+16 -01 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchDaniel P. BerrangéWilfred MallawaPhilippe Mathieu-Daudé
1/3
2/3
3/3R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [RFC PATCH 0/3] Deprecate the qemu-system-i386 binary

Allow running qemu-system-x86_64 in 32-bit-only mode (by renaming or symlinking the binary to "qemu-system-i386"). After doing this, qemu-system-x86_64 should be a proper superset of qemu-system-i386 (apart from 32-bit KVM support, which however is not really required anymore, see https://lore.kernel.org/kvm/Y%[email protected]/ ). Thus we can finally deprecate the qemu-system-i386 binary. This will help to avoid that we have to compile a lot of the x86 stuff twice once we'll finally be able to drop qemu-system-i386.

Marked as RFC since there are likely still a bunch of spots around that need attention, e.g.:

- CPU types have different suffixes between the -x86_64 and -i386 variant (see TYPE_X86_CPU in cpu-qom.h) ... do we need to care about this in the new qemu-system-i386 symlink run mode?

- The code in target/i386/tcg/sysemu/smm_helper.c looks like it maybe needs a runtime switch, too ... or is it ok to leave this hard-coded to the x86_64 version?

Anyway, I'd like to get some feedback on this idea here... What do you think of the idea of getting rid of the qemu-system-i386 binary this way in the future?

Thomas Huth (3):
cpu: Add a way to detect 32-bit mode from argv0 target/i386/cpu: Allow to limit the 64-bit binary to 32-bit mode only docs/about/deprecated: Deprecate the qemu-system-i386 binary

 docs/about/deprecated.rst | 16 ++++++++++++++++
 include/hw/core/cpu.h     | 10 ++++++++++
 target/i386/cpu.h         |  4 ++--
 cpu.c                     | 13 +++++++++++++
 softmmu/vl.c              |  1 +
 target/i386/cpu.c         | 28 +++++++++++++---------------
 target/i386/gdbstub.c     |  8 +-------
 7 files changed, 56 insertions(+), 24 deletions(-)
Signature · 1 line
2.31.1