drm,fbdev: Use fbdev's I/O helpers
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest19 patches 20 repliesIn review
- v16 patches 31 repliesSuperseded
Changes in v2 from the cover letter
* fix screen_base vs. screen_buffer usage
* fix copy_{from,to}_user() return value (Geert)
* use fb_io_() prefix (Geert)
* improved commit messages
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | auxdisplay/cfag12864bfb: Use struct fb_info.screen_bufferdrivers/ | +1 | 1 reply | |
| 2/19 | auxdisplay/ht16k33: Use struct fb_info.screen_bufferdrivers/ | +1 | 1 reply | |
| 3/19 | hid/hid-picolcd_fb: Use struct fb_info.screen_bufferdrivers/ | +2 | 1 reply | |
| 4/19 | fbdev/arcfb: Use struct fb_info.screen_bufferdrivers/ | +4 | 1 reply | |
| 5/19 | fbdev/au1200fb: Use struct fb_info.screen_bufferdrivers/ | +1 | 1 reply | |
| 6/19 | fbdev/broadsheetfb: Use struct fb_info.screen_bufferdrivers/ | +6 | 1 reply | |
| 7/19 | fbdev/hecubafb: Use struct fb_info.screen_bufferdrivers/ | +4 | 1 reply | |
| 8/19 | fbdev/metronomefb: Use struct fb_info.screen_bufferdrivers/ | +6 | 1 reply | |
| 9/19 | fbdev/ps3fb: Use struct fb_info.screen_bufferdrivers/ | +2 | 1 reply | |
| 10/19 | fbdev/smscufx: Use struct fb_info.screen_bufferdrivers/ | +7 | 1 reply | |
| 11/19 | fbdev/udlfb: Use struct fb_info.screen_bufferdrivers/ | +6 | 1 reply | |
| 12/19 | fbdev/vfb: Use struct fb_info.screen_bufferdrivers/ | +1 | 1 reply | |
| 13/19 | fbdev/xen-fbfront: Use struct fb_info.screen_bufferdrivers/ | +1 | 1 reply | |
| 14/19 | fbdev: Return number of bytes read or writtendrivers/ drivers/ | +24 | 0 replies | |
| 15/19 | fbdev: Use screen_buffer in fb_sys_{read,write}()drivers/ | +2 | 0 replies | |
| 16/19 | fbdev: Don't re-validate info->state in fb_ops implementationsdrivers/ drivers/ drivers/ +3 more | +0 | 0 replies | |
| 17/19 | fbdev: Validate info->screen_{base, buffer} in fb_ops implementationsdrivers/ drivers/ drivers/ +8 more | +43 | 4 replies | |
| 18/19 | fbdev: Move I/O read and write code into helper functionsdrivers/ drivers/ drivers/ +1 more | +146 | 2 replies | |
| 19/19 | drm/fb-helper: Use fb_{cfb,sys}_{read, write}()drivers/ | +4 | 1 reply |
Reviews trailers per patch
All 19 patches have a Reviewed-by or Acked-by.
| Patch | Sui Jingfeng | Javier Martinez Canillas | Geert Uytterhoeven | Helge Deller | Sam Ravnborg |
|---|---|---|---|---|---|
| 1/19 | R-b | ||||
| 2/19 | R-b | ||||
| 3/19 | R-b | ||||
| 4/19 | R-b | ||||
| 5/19 | R-b | ||||
| 6/19 | R-b | ||||
| 7/19 | R-b | ||||
| 8/19 | R-b | ||||
| 9/19 | R-b | ||||
| 10/19 | R-b | ||||
| 11/19 | R-b | ||||
| 12/19 | R-b | ||||
| 13/19 | R-b | ||||
| 14/19 | T-b | R-b | R-b | A-b | |
| 15/19 | T-b | R-b | R-b | A-b | |
| 16/19 | T-b | R-b | R-b | A-b | |
| 17/19 | T-b | R-b | A-b | ||
| 18/19 | T-b | R-b | A-b | R-b | |
| 19/19 | T-b | R-b | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v2 00/19] drm,fbdev: Use fbdev's I/O helpers
Make fbdev's built-in helpers for reading and writing I/O and system memory available to DRM. Replace DRM's internal helpers.
The first 13 patches and patch 15 fix the use of screen_base and screen_buffer. A number of drivers mix them up.
Patch 14 resolves a bug that's been in the fbdev code for more than 15 years. Makes the read/write helpers work successfully with the IGT tests.
Patches 16 and 17 streamline fbdev's file-I/O code and remove a few duplicate checks.
Patch 18 moves the default-I/O code into the new helpers fb_io_read() and fb_io_write(); patch 19 uses them in DRM. This allows us to remove quite a bit of code from DRM's internal fbdev helpers.
Tested with i915 and simpledrm.
The next step here is to remove the drm_fb_helper_{cfb,sys}_*() entirely. They where mostly introduced because fbdev doesn't protect it's public interfaces with an CONFIG_FB preprocessor guards. But all of DRM driver's fbdev emulation won't be build without CONFIG_FB, so this is not an issue in practice. Removing the DRM wrappers will further simplify the DRM code.
v2:
* fix screen_base vs. screen_buffer usage
* fix copy_{from,to}_user() return value (Geert)
* use fb_io_() prefix (Geert)
* improved commit messages
Thomas Zimmermann (19):
auxdisplay/cfag12864bfb: Use struct fb_info.screen_buffer auxdisplay/ht16k33: Use struct fb_info.screen_buffer hid/hid-picolcd_fb: Use struct fb_info.screen_buffer fbdev/arcfb: Use struct fb_info.screen_buffer fbdev/au1200fb: Use struct fb_info.screen_buffer fbdev/broadsheetfb: Use struct fb_info.screen_buffer fbdev/hecubafb: Use struct fb_info.screen_buffer fbdev/metronomefb: Use struct fb_info.screen_buffer fbdev/ps3fb: Use struct fb_info.screen_buffer fbdev/smscufx: Use struct fb_info.screen_buffer fbdev/udlfb: Use struct fb_info.screen_buffer
fbdev/vfb: Use struct fb_info.screen_buffer fbdev/xen-fbfront: Use struct fb_info.screen_buffer
fbdev: Return number of bytes read or written
fbdev: Use screen_buffer in fb_sys_{read,write}()
fbdev: Don't re-validate info->state in fb_ops implementations
fbdev: Validate info->screen_{base,buffer} in fb_ops implementations
fbdev: Move I/O read and write code into helper functions drm/fb-helper: Use fb_{cfb,sys}_{read, write}()
drivers/auxdisplay/cfag12864bfb.c | 2 +- drivers/auxdisplay/ht16k33.c | 2 +- drivers/gpu/drm/drm_fb_helper.c | 174 +------------------------ drivers/hid/hid-picolcd_fb.c | 4 +- drivers/media/pci/ivtv/ivtvfb.c | 4 +- drivers/video/fbdev/arcfb.c | 11 +- drivers/video/fbdev/au1200fb.c | 2 +- drivers/video/fbdev/broadsheetfb.c | 16 +-- drivers/video/fbdev/cobalt_lcdfb.c | 6 + drivers/video/fbdev/core/Makefile | 2 +- drivers/video/fbdev/core/fb_io_fops.c | 133 +++++++++++++++++++ drivers/video/fbdev/core/fb_sys_fops.c | 36 ++--- drivers/video/fbdev/core/fbmem.c | 111 +--------------- drivers/video/fbdev/hecubafb.c | 12 +- drivers/video/fbdev/metronomefb.c | 16 +-- drivers/video/fbdev/ps3fb.c | 4 +- drivers/video/fbdev/pvr2fb.c | 3 + drivers/video/fbdev/sm712fb.c | 10 +- drivers/video/fbdev/smscufx.c | 14 +- drivers/video/fbdev/ssd1307fb.c | 3 + drivers/video/fbdev/udlfb.c | 12 +- drivers/video/fbdev/vfb.c | 2 +- drivers/video/fbdev/xen-fbfront.c | 2 +- include/linux/fb.h | 10 ++ 24 files changed, 239 insertions(+), 352 deletions(-) create mode 100644 drivers/video/fbdev/core/fb_io_fops.c
Signature · 1 line
2.40.0