Skip to content

vmstate-static-checker: Fix VMS_ARRAY comparisons

Peter Xu qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2migration/vmstate-dump: Dump array size too as "num"migration/savevm.c+3 -01 reply
2/2vmstate-static-checker: Recognize "num" fieldscripts/vmstate-static-checker.py+10 -31 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJuan Quintela
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] vmstate-static-checker: Fix VMS_ARRAY comparisons

I'm doing some machine type checks to make sure nothing breaks for 7.2<->8.0. Along the way I found one false negative report on e1000e using the static checker, turns out to be an issue in the checker itself.

The problem is the checker doesn't take VMS_ARRAY into account when comparing with UNUSED, hence the total size is wrongly calculated.

Fix that first in qemu by start dumping size of array as "num", then teach the checker for that.

NOTE: the patchset will change both behaviors for either -dump-vmstate on QEMU or the checker, however both patches will be compatible even with old QEMU dumps or even old vmstate-checker script. That's not extremely important, IMHO, but still worth mentioning.

Thanks,

Peter Xu (2):
migration/vmstate-dump: Dump array size too as "num"
vmstate-static-checker: Recognize "num" field

 migration/savevm.c                |  3 +++
 scripts/vmstate-static-checker.py | 13 ++++++++++---
 2 files changed, 13 insertions(+), 3 deletions(-)
Signature · 1 line
2.39.1