Skip to content

selftests/bpf: test_progs can read test lists from file

Stephen Veiss bpf 2 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesApplied 2/2
  2. v12 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- error handling style changes per reviewer comments
- fdopen return value checking in test_parse_test_list_file

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2selftests/bpf: extract insert_test from parse_test_listtools/testing/selftests/bpf/prog_tests/arg_parsing.c tools/testing/selftests/bpf/testing_helpers.c+117 -741 replyApplied
2/2selftests/bpf: test_progs can read test lists from filetools/testing/selftests/bpf/prog_tests/arg_parsing.c tools/testing/selftests/bpf/test_progs.c tools/testing/selftests/bpf/testing_helpers.c +1 more+132 -101 replyApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchYonghong Song
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH bpf-next v2 0/2] selftests/bpf: test_progs can read test lists from file

BPF selftests have ALLOWLIST and DENYLIST files, used to control which tests are run in CI. These files are currently parsed by a shell script. [1]

This patchset allows those files to be specified directly on the test_progs command line (eg, as -a @ALLOWLIST).

This also fixes a bug in the existing test filter code causing unnecessary duplicate top-level test filter entries to be created.

[1] https://github.com/kernel-patches/vmtest/blob/57feb460047b69f891cf4afe3cc860794a2ced17/ci/vmtest/run_selftests.sh#L21-L27

---

v2:
- error handling style changes per reviewer comments
- fdopen return value checking in test_parse_test_list_file

v1:
https://lore.kernel.org/bpf/[email protected]/

Stephen Veiss (2):
selftests/bpf: extract insert_test from parse_test_list selftests/bpf: test_progs can read test lists from file

 .../selftests/bpf/prog_tests/arg_parsing.c    |  68 ++++++
 tools/testing/selftests/bpf/test_progs.c      |  37 ++-
 tools/testing/selftests/bpf/testing_helpers.c | 225 ++++++++++++------
 tools/testing/selftests/bpf/testing_helpers.h |   3 +
 4 files changed, 249 insertions(+), 84 deletions(-)

base-commit: b580dac290822cfcbe741c0aa59c41c3fda398a8

Signature · 1 line
2.34.1