Skip to content

target/s390x: Fix EXECUTE of relative branches

Ilya Leoshkevich qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2target/s390x: Fix EXECUTE of relative branchestarget/s390x/tcg/translate.c+58 -231 reply
2/2tests/tcg/s390x: Test EXECUTE of relative branchestests/tcg/s390x/Makefile.target tests/tcg/s390x/ex-branch.c+159 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRichard Henderson
1/2R-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] target/s390x: Fix EXECUTE of relative branches

Hi,

This series fixes EXECUTing relative branches: currently the offset is incorrectly applied to EXECUTE and not the branch itself. This is similar to what I previously fixed for load/store instructions.

Unfortunately here it's not feaisble to use the ri2 field, since it would break the direct branch optimization. Instead, introduce the disas_jdest() macro and pass its output to help_branch().

Patch 1 is the fix, patch 2 is the test.

Best regards,
Ilya

Ilya Leoshkevich (2):
target/s390x: Fix EXECUTE of relative branches tests/tcg/s390x: Test EXECUTE of relative branches

 target/s390x/tcg/translate.c    |  81 +++++++++++-----
 tests/tcg/s390x/Makefile.target |   1 +
 tests/tcg/s390x/ex-branch.c     | 158 ++++++++++++++++++++++++++++++++
 3 files changed, 217 insertions(+), 23 deletions(-)
 create mode 100644 tests/tcg/s390x/ex-branch.c
Signature · 1 line
2.40.0