Skip to content

fcntl{34,36}: Fixes for Android arm64

Edward Liaw via ltp ltp 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 5 repliesSuperseded

Changes in v2 from the cover letter

Updated commit description and cleaned up error message.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2fcntl{34, 36}: Only use fcntl64 with 32bit abitestcases/kernel/syscalls/fcntl/fcntl_common.h+10 -61 reply
2/2fcntl{34, 36}: Use arch dependent types for my_flock64testcases/kernel/syscalls/fcntl/fcntl_common.h+6 -62 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPetr Vorel
1/2R-b
2/2R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [LTP] [PATCH v2 0/2] fcntl{34,36}: Fixes for Android arm64
Fixes 7643115aaacb ("fcntl{34,36}: Always use 64-bit flock struct to avoid EINVAL")

In Richard's commit I think that he had meant to write that the flock64 type (not fcntl64 type) had been removed from some libcs. I believe that was the reason why he added the my_flock64 type.

On Android arm64, this test was breaking for two reasons:

1. The my_flock64 type definition did not match the expected type when compiled for 64 bits.
2. The test was mixing fcntl and the flock64 struct when compiled for 32 bits.

Both seem to be ok on x86_64 but not on arm64. To fix it, I gated the compat function on TST_ABI64 instead of tst_kernel_bits.

v1->v2:
Updated commit description and cleaned up error message.

Edward Liaw (2):
fcntl{34,36}: Only use fcntl64 with 32bit abi fcntl{34,36}: Use arch dependent types for my_flock64

 .../kernel/syscalls/fcntl/fcntl_common.h      | 28 +++++++++++--------
 1 file changed, 16 insertions(+), 12 deletions(-)

--
2.40.1.495.gc816e09b53d-goog

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp