Skip to content

RFC nvme-core: dhchap_secret code cleanup

Chaitanya Kulkarni linux-nvme 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2nvme-core: factor out common code into helperdrivers/nvme/host/core.c+31 -542 replies
2/2nvme-core: use macro defination to define dev attrdrivers/nvme/host/core.c+27 -441 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC COMPILE ONLY PATCH 0/2] nvme-core: dhchap_secret code cleanup

Hi,

Marking it compile only RFC since blktests are failing on current nvme-6.4 so I was not able to complete the testing.

Bunch of code is repeated all over when defining nvme_ctrl_dhchap_secret and nvme_ctrl_dhchap_ctrl_secret. Factor out a common function for nvme_ctrl_secret_dhchap_store() and nvme_ctrl_secret_dhchap_ctrl_store() into common function nvme_dhchap_secret_store_common().

Add a macro to define device attr in order to remove code duplication for above mentioned attributes.

No functional changes in this patch-series.

-ck

Chaitanya Kulkarni (2):
nvme-core: factor out common code into helper
nvme-core: use macro defination to define dev attr

 drivers/nvme/host/core.c | 128 ++++++++++++++-------------------------
 1 file changed, 44 insertions(+), 84 deletions(-)
Signature · 1 line
2.40.0