Skip to content

net: tcp: make txhash use consistent for IPv4

Antoine Tenart netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net: tcp: make the txhash available in TIME_WAIT sockets for IPv4 toonet/ipv4/tcp_minisocks.c+1 -10 replies
2/4net: ipv4: use consistent txhash in TIME_WAIT and SYN_RECVinclude/net/ip.h net/ipv4/ip_output.c net/ipv4/tcp_ipv4.c+13 -70 replies
3/4Documentation: net: net.core.txrehash is not specific to listening socketsDocumentation/admin-guide/sysctl/net.rst+2 -20 replies
4/4net: skbuff: fix l4_hash commentinclude/linux/skbuff.h+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/4] net: tcp: make txhash use consistent for IPv4

Hello,

Series is divided in two parts. First two commits make the txhash (used for the skb hash in TCP) to be consistent for all IPv4/TCP packets (IPv6 doesn't have the same issue). Last two commits improve doc/comment hash-related parts.

One example is when using OvS with dp_hash, which uses skb->hash, to select a path. We'd like packets from the same flow to be consistent, as well as the hash being stable over time when using net.core.txrehash=0. Same applies for kernel ECMP which also can use skb->hash.

IMHO the series makes sense in net-next, but we could argue (some) commits be seen as fixes and I can resend if necessary.

Thanks!
Antoine

Antoine Tenart (4):
net: tcp: make the txhash available in TIME_WAIT sockets for IPv4 too
net: ipv4: use consistent txhash in TIME_WAIT and SYN_RECV
Documentation: net: net.core.txrehash is not specific to listening
sockets
net: skbuff: fix l4_hash comment

 Documentation/admin-guide/sysctl/net.rst |  4 ++--
 include/linux/skbuff.h                   |  4 ++--
 include/net/ip.h                         |  2 +-
 net/ipv4/ip_output.c                     |  4 +++-
 net/ipv4/tcp_ipv4.c                      | 14 +++++++++-----
 net/ipv4/tcp_minisocks.c                 |  2 +-
 6 files changed, 18 insertions(+), 12 deletions(-)
Signature · 1 line
2.40.0