Skip to content

rxrpc: Timeout handling fixes

David Howells lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesApplied 3/3

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3rxrpc: Fix hard call timeout unitsnet/rxrpc/sendmsg.c+1 -10 repliesApplied
2/3rxrpc: Make it so that a waiting process can be abortednet/rxrpc/sendmsg.c+5 -20 repliesApplied
3/3rxrpc: Fix timeout of a call that hasn't yet been granted a channelfs/afs/afs.h fs/afs/internal.h fs/afs/rxrpc.c +5 more+30 -190 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 0/3] rxrpc: Timeout handling fixes

Here are three patches to fix timeouts handling in AF_RXRPC:

(1) The hard call timeout should be interpreted in seconds, not milliseconds.

(2) Allow a waiting call to be aborted (thereby cancelling the call) in the case a signal interrupts sendmsg() and leaves it hanging until it is granted a channel on a connection.

(3) Kernel-generated calls get the timer started on them even if they're still waiting to be attached to a connection. If the timer expires before the wait is complete and a conn is attached, an oops will occur.

David

---
The patches can be found here also:

http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes

David Howells (3):
rxrpc: Fix hard call timeout units
rxrpc: Make it so that a waiting process can be aborted
rxrpc: Fix timeout of a call that hasn't yet been granted a channel

 fs/afs/afs.h            |  4 ++--
 fs/afs/internal.h       |  2 +-
 fs/afs/rxrpc.c          |  8 +++-----
 include/net/af_rxrpc.h  | 21 +++++++++++----------
 net/rxrpc/af_rxrpc.c    |  3 +++
 net/rxrpc/ar-internal.h |  1 +
 net/rxrpc/call_object.c |  9 ++++++++-
 net/rxrpc/sendmsg.c     | 10 +++++++---
 8 files changed, 36 insertions(+), 22 deletions(-)