Skip to content

drm/xe: Rework multi tile device memory initialization

Michael J. Ruhl intel-xe 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest4 patches 1 replyIn review
  2. v64 patches 2 repliesSuperseded
  3. v54 patches 7 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v44 patches9 repliesSuperseded
v34 patches9 repliesSuperseded
v2 posting 2/24 patches0 repliesSuperseded
v2 posting 1/24 patches0 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/xe: Rework size helper to be a little more correctdrivers/gpu/drm/xe/regs/xe_gt_regs.h drivers/gpu/drm/xe/xe_mmio.c drivers/gpu/drm/xe/xe_mmio.h +1 more+74 -480 replies
2/4drm/xe: Simplify rebar sizingdrivers/gpu/drm/xe/xe_device_types.h drivers/gpu/drm/xe/xe_gt_types.h drivers/gpu/drm/xe/xe_mmio.c+89 -680 replies
3/4drm/xe: Size GT device memory correctlydrivers/gpu/drm/xe/xe_device_types.h drivers/gpu/drm/xe/xe_gt_types.h drivers/gpu/drm/xe/xe_mmio.c+51 -460 replies
4/4drm/xe: Rename GPU offset helper to reflect true usagedrivers/gpu/drm/xe/xe_bo.c drivers/gpu/drm/xe/xe_bo.h drivers/gpu/drm/xe/xe_migrate.c +1 more+8 -110 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMatthew Auld
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [Intel-xe] [PATCH v7 0/4] drm/xe: Rework multi tile device memory initialization

The vram initialization path does not take into account each tile's actual memory size.

While updating this, simplify the rebar algorithm and clarify some helper functions.

v2: Address review comments
- separate tile sizing to the initial patch
v3: Re-add deleted warning for small bar systems
v4: Address review comments
- stolen size check should be against pci resource
- limit size (patch 2) to keep bisection correct
v5: Include actual memory size for Xe level for use (1:1 map for xe_migrate,
for example)
v6: Limit gt memory size to visible size (small bar)
Fix forced resize missed __fls
v7: Use GPU offset information (helper) for PT rather than IO offset

Michael J. Ruhl (4):
drm/xe: Rework size helper to be a little more correct drm/xe: Simplify rebar sizing
drm/xe: Size GT device memory correctly drm/xe: Rename GPU offset helper to reflect true usage

 drivers/gpu/drm/xe/regs/xe_gt_regs.h   |   2 +-
 drivers/gpu/drm/xe/xe_bo.c             |   8 +-
 drivers/gpu/drm/xe/xe_bo.h             |   2 +-
 drivers/gpu/drm/xe/xe_device_types.h   |  16 +-
 drivers/gpu/drm/xe/xe_gt_types.h       |  14 +-
 drivers/gpu/drm/xe/xe_migrate.c        |   4 +-
 drivers/gpu/drm/xe/xe_mmio.c           | 276 ++++++++++++++-----------
 drivers/gpu/drm/xe/xe_mmio.h           |   6 +-
 drivers/gpu/drm/xe/xe_pt.c             |   5 +-
 drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c |  34 +--
 10 files changed, 208 insertions(+), 159 deletions(-)
Signature · 1 line
2.39.2