Skip to content

xe_device_mem_access fixes and related bits

Matthew Auld intel-xe 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v15 Latest10 patches 2 repliesIn review
  2. v1410 patches 0 repliesSuperseded
  3. v1310 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v1213 patches15 repliesSuperseded
v1112 patches9 repliesSuperseded
v11 patch6 repliesSuperseded

Changes in v15 from the cover letter

- Rebase on latest drm-xe-next.

Patches in v15 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/xe: fix xe_device_mem_access_get() racesdrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device.h drivers/gpu/drm/xe/xe_device_types.h +3 more+135 -530 replies
2/10drm/xe/vm: tidy up xe_runtime_pm usagedrivers/gpu/drm/xe/xe_vm.c+2 -80 replies
3/10drm/xe/debugfs: grab mem_access around forcewakedrivers/gpu/drm/xe/xe_debugfs.c+4 -00 replies
4/10drm/xe/guc_pc: add missing mem_access for freq_rpe_showdrivers/gpu/drm/xe/xe_guc_pc.c+4 -00 replies
5/10drm/xe/mmio: grab mem_access in xe_mmio_ioctldrivers/gpu/drm/xe/xe_mmio.c+2 -02 replies
6/10drm/xe: ensure correct access_put orderingdrivers/gpu/drm/xe/xe_gt.c drivers/gpu/drm/xe/xe_gt_debugfs.c drivers/gpu/drm/xe/xe_guc_pc.c+6 -60 replies
7/10drm/xe: drop xe_device_mem_access_get() from guc_ct_senddrivers/gpu/drm/xe/xe_guc_ct.c+0 -40 replies
8/10drm/xe/ggtt: prime ggtt->lock against FS_RECLAIMdrivers/gpu/drm/xe/xe_ggtt.c+11 -00 replies
9/10drm/xe: drop xe_device_mem_access_get() from invalidation_vmadrivers/gpu/drm/xe/xe_gt_tlb_invalidation.c+2 -60 replies
10/10drm/xe: add lockdep annotation for xe_device_mem_access_get()drivers/gpu/drm/xe/xe_device.c+24 -00 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchAnshuman GuptaRodrigo ViviMatthew Brost
1/10A-b R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v15 thread

Cover letter [Intel-xe] [PATCH v15 00/10] xe_device_mem_access fixes and related bits

Main goal is to fix the races in xe_device_mem_access_get(). With that fixed we can clean up some hacks and also start rolling it out to more places that need it, including now asserting it around every mmio access. We also add lockdep annotations for xe_device_mem_access_get() and fix the remaining lockdep fallout.

v11 -> v12:
- freq_rpe_show also needs the device to be awake
- Improvements to the lockdep annotation patch
v13:
- Simply the first patch (Anshuman), also drop three patches which can be dealt with later.
v14:
- Missed also updating the fast CT path which recently changed.
v15:
- Rebase on latest drm-xe-next.

Signature · 1 line
2.41.0