Skip to content

ufs: Do not requeue while ungating the clock

Bart Van Assche linux-scsi 5 versions – Applied

Status from this message: Applied to 6.5/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest posting 2/25 patches 7 repliesApplied
  2. v4 posting 1/25 patches 1 replySuperseded
  3. v34 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches11 repliesSuperseded
v15 patches7 repliesSuperseded

Changes in v4 from the cover letter

- Added a patch that removes two duplicate declarations.

Patches in v4 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/5scsi: core: Rework scsi_host_block()drivers/scsi/scsi_lib.c+13 -50 replies
2/5scsi: core: Support setting BLK_MQ_F_BLOCKINGdrivers/scsi/hosts.c drivers/scsi/scsi_lib.c include/scsi/scsi_host.h+11 -70 replies
3/5scsi: ufs: Conditionally enable the BLK_MQ_F_BLOCKING flagdrivers/ufs/core/ufshcd.c+1 -01 reply
4/5scsi: ufs: Declare ufshcd_{hold,release}() oncedrivers/ufs/core/ufshcd-priv.h+0 -32 replies
5/5scsi: ufs: Ungate the clock synchronouslydrivers/ufs/core/ufs-sysfs.c drivers/ufs/core/ufshcd-crypto.c drivers/ufs/core/ufshcd.c +1 more+30 -622 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchMike ChristieMing LeiAdrian HunterBean HuoBao D. NguyenKeoseong Park
1/5R-b R-b
2/5
3/5A-b R-b
4/5R-b R-b
5/5A-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/5] ufs: Do not requeue while ungating the clock

Hi Martin,

In the traces we recorded while testing zoned storage we noticed that UFS commands are requeued while the clock is being ungated. Command requeueing makes it harder than necessary to preserve the command order. Hence this patch series that modifies the SCSI core and also the UFS driver such that clock ungating does not trigger command requeueing.

Please consider this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v3:
- Added a patch that removes two duplicate declarations.

Changes compared to v2:
- Only enable BLK_MQ_F_BLOCKING if clock gating is supported.
- Introduce flag queuecommand_may_block in both the SCSI host and SCSI host template data structures.

Changes compared to v1:
- Dropped patch "scsi: ufs: core: Unexport ufshcd_hold() and ufshcd_release()".
- Removed a ufshcd_scsi_block_requests() / ufshcd_scsi_unblock_requests() pair from patch "scsi: ufs: Ungate the clock synchronously".

Bart Van Assche (4):
scsi: core: Rework scsi_host_block()
scsi: core: Support setting BLK_MQ_F_BLOCKING
scsi: ufs: Conditionally enable the BLK_MQ_F_BLOCKING flag
scsi: ufs: Ungate the clock synchronously

Bart Van Assche (5):
scsi: core: Rework scsi_host_block()
scsi: core: Support setting BLK_MQ_F_BLOCKING
scsi: ufs: Conditionally enable the BLK_MQ_F_BLOCKING flag
scsi: ufs: Declare ufshcd_{hold,release}() once
scsi: ufs: Ungate the clock synchronously

 drivers/scsi/hosts.c             |  1 +
 drivers/scsi/scsi_lib.c          | 27 ++++++----
 drivers/ufs/core/ufs-sysfs.c     |  2 +-
 drivers/ufs/core/ufshcd-crypto.c |  2 +-
 drivers/ufs/core/ufshcd-priv.h   |  3 --
 drivers/ufs/core/ufshcd.c        | 87 ++++++++++----------------------
 include/scsi/scsi_host.h         |  6 +++
 include/ufs/ufshcd.h             |  2 +-
 8 files changed, 54 insertions(+), 76 deletions(-)