Skip to content

KVM: s390: add counters for vsie performance

Nico Boehr kvm linux-s390 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 4 repliesIn review
  2. v32 patches 5 repliesSuperseded
  3. v22 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches10 repliesSuperseded

Changes in v4 from the cover letter

---
* fix indent in tracepoint (thanks Janosch)

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2KVM: s390: add stat counter for shadow gmap eventsarch/s390/include/asm/kvm_host.h arch/s390/kvm/gaccess.c arch/s390/kvm/kvm-s390.c +1 more+26 -22 replies
2/2KVM: s390: add tracepoint in gmap notifierarch/s390/kvm/kvm-s390.c arch/s390/kvm/trace-s390.h+25 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDavid HildenbrandClaudio ImbrendaJanosch Frank
1/2R-b R-b R-b
2/2A-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/2] KVM: s390: add counters for vsie performance

v4:
---
* fix indent in tracepoint (thanks Janosch)

v3:
---
* rename te -> entry (David)
* add counters for gmap reuse and gmap create (David)

v2:
---
* also count shadowing of pages (Janosch)
* fix naming of counters (Janosch)
* mention shadowing of multiple levels is counted in each level (Claudio)
* fix inaccuate commit description regarding gmap notifier (Claudio)

When running a guest-3 via VSIE, guest-1 needs to shadow the page table structures of guest-2.

To reflect changes of the guest-2 in the _shadowed_ page table structures, the _shadowing_ sturctures sometimes need to be rebuilt. Since this is a costly operation, it should be avoided whenever possible.

This series adds kvm stat counters to count the number of shadow gmaps created and a tracepoint whenever something is unshadowed. This is a first step to try and improve VSIE performance.

Please note that "KVM: s390: add tracepoint in gmap notifier" has some checkpatch --strict findings. I did not fix these since the tracepoint definition would then look completely different from all the other tracepoints in arch/s390/kvm/trace-s390.h. If you want me to fix that, please let me know.

Nico Boehr (2):
KVM: s390: add stat counter for shadow gmap events
KVM: s390: add tracepoint in gmap notifier

 arch/s390/include/asm/kvm_host.h |  7 +++++++
 arch/s390/kvm/gaccess.c          |  7 +++++++
 arch/s390/kvm/kvm-s390.c         | 11 ++++++++++-
 arch/s390/kvm/trace-s390.h       | 23 +++++++++++++++++++++++
 arch/s390/kvm/vsie.c             |  5 ++++-
 5 files changed, 51 insertions(+), 2 deletions(-)
Signature · 1 line
2.41.0