Skip to content

Reworking configurability of X86_FEATURE_NAMES

Lukas Bulwahn kernel-janitors lkml 1 version Applied

Status from this message: The following commit has been merged into the x86/cpu branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2x86: make X86_FEATURE_NAMES non-configurable in promptarch/x86/Kconfig+1 -10 replies
2/2x86: always build with X86_FEATURE_NAMES functionalityarch/x86/Kconfig arch/x86/Kconfig.cpu arch/x86/boot/Makefile +4 more+2 -400 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Reworking configurability of X86_FEATURE_NAMES

Dear Dave, dear Boris, dear x86 maintainers,

as follow-up to the discussion on my initial patch on changing the visibility of X86_FEATURE_NAMES (see Link), here are two patches:

Patch 1 simply makes the minimal one-line change to make X86_FEATURE_NAMES disappear from the prompt.

Patch 2 is the more radical change to remove the whole config and see which code would generally be impacted; just as quick exploration.

The diffstat shows we are getting rid of a bit of code throughout arch/x86, but the change and reduction is not too complex either:

 arch/x86/Kconfig                  | 12 ------------
 arch/x86/Kconfig.cpu              |  2 +-
 arch/x86/boot/Makefile            |  2 --
 arch/x86/boot/cpu.c               | 13 -------------
 arch/x86/include/asm/cpufeature.h |  5 -----
 arch/x86/kernel/cpu/Makefile      |  4 +---
 arch/x86/kernel/cpu/common.c      |  4 ----
 7 files changed, 2 insertions(+), 40 deletions(-)

Probably, you just want to pick patch 1 and wait for any complaints. Or if you are confident the compliants will not show up, simply apply both.

Otherwise, I will put it on my list to come back in a year or two, and if there were no complaints till then, provide the updated patch to remove the X86_FEATURE_NAMES config then.

Best regards,

Lukas

Lukas Bulwahn (2):
x86: make X86_FEATURE_NAMES non-configurable in prompt
x86: always build with X86_FEATURE_NAMES functionality

 arch/x86/Kconfig                  | 12 ------------
 arch/x86/Kconfig.cpu              |  2 +-
 arch/x86/boot/Makefile            |  2 --
 arch/x86/boot/cpu.c               | 13 -------------
 arch/x86/include/asm/cpufeature.h |  5 -----
 arch/x86/kernel/cpu/Makefile      |  4 +---
 arch/x86/kernel/cpu/common.c      |  4 ----
 7 files changed, 2 insertions(+), 40 deletions(-)
Signature · 1 line
2.17.1