Skip to content

2 fixes for recv-msgall.c

Ammar Faizi io-uring lkml 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2recv-msgall: Fix undefined behavior in `recv_prep()`test/recv-msgall.c+15 -130 replies
2/2recv-msgall: Fix invalid mutex usagetest/recv-msgall.c+7 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH liburing v1 0/2] 2 fixes for recv-msgall.c

Hi Jens,

This is the follow up patchset for the recent issue found in recv-msgall.c. There are two patches in this series.

1. Fix undefined behavior in recv_prep().
The lifetime of struct msghdr msg; must be long enough until the CQE is generated because the recvmsg operation will write to that storage. I found this test segfault when compiling with -O0 optimization. This is undefined behavior and may behave randomly. Fix this by making the lifetime of struct msghdr msg; long enough.

2. Fix invalid mutex usage.
Calling pthread_mutex_lock() twice with the same mutex in the same thread without unlocking it first is invalid. The intention behind this pattern was to wait for the recv_fn() thread to be ready. Use the pthread barrier instead. It is more straightforward and correct.

Please apply!

---

Ammar Faizi (2):
recv-msgall: Fix undefined behavior in recv_prep()
recv-msgall: Fix invalid mutex usage

 test/recv-msgall.c | 44 +++++++++++++++++++++-----------------------
 1 file changed, 21 insertions(+), 23 deletions(-)

base-commit: 4961ac480052089a94978e9f771d513551aff61b

Signature · 1 line
Ammar Faizi