Skip to content

Add PASID support to SMMUv3 unmanaged domains

Michael Shavit linux-arm-kernel linux-iommu lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 8 repliesIn review
  2. v413 patches 37 repliesSuperseded
  3. v313 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v218 patches16 repliesSuperseded
v15 patches11 repliesSuperseded

Changes in v5 from the cover letter

- Renamed domain_head to list for consistency with other lists
- Renamed attached_domains to attached_ssids to avoid confusion. This is
a list of master/ssid pairs the domain is attached to, not a list of
other domains.
- Fix missing error value return in set_dev_pasid
- Fix issue where nr_attached_pasid_domains isn't updated when
arm_smmu_write_ctx_desc fails
- Fix missing free of the attached_domain node
- Split off the CD table refactor to separate patch series: https://lore.kernel.org/all/[email protected]/
- Link to v4: https://lore.kernel.org/all/[email protected]/
- New commit: Free attached pasid domains on release_device() call

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6iommu/arm-smmu-v3: Simplify arm_smmu_enable_atsdrivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c+1 -10 replies
2/6iommu/arm-smmu-v3: Keep track of attached ssidsdrivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h+98 -513 replies
3/6iommu/arm-smmu-v3: Add helper for atc invalidationdrivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c+8 -10 replies
4/6iommu/arm-smmu-v3: Implement set_dev_pasiddrivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h+141 -161 reply
5/6iommu/arm-smmu-v3: Free pasid domains on iommu releasedrivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h+25 -72 replies
6/6iommu/arm-smmu-v3: Cleanup arm_smmu_domain_finalisedrivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c+6 -112 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchJason Gunthorpe
1/6
2/6
3/6
4/6
5/6
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/6] Add PASID support to SMMUv3 unmanaged domains

This patch series implements the set_dev_pasid operation for DMA and UNMANAGED iommu domains. The series depends on the CD table refactor patch series as a pre-requisite.

This patch series is also available on gerrit with Jean's SMMU test
engine patches cherry-picked along with an additional set of tests for
this feature: https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/24770/6

Thanks,
Michael Shavit

Changes in v5:
- Renamed domain_head to list for consistency with other lists
- Renamed attached_domains to attached_ssids to avoid confusion. This is
a list of master/ssid pairs the domain is attached to, not a list of
other domains.
- Fix missing error value return in set_dev_pasid
- Fix issue where nr_attached_pasid_domains isn't updated when
arm_smmu_write_ctx_desc fails
- Fix missing free of the attached_domain node
- Split off the CD table refactor to separate patch series: https://lore.kernel.org/all/[email protected]/
- Link to v4: https://lore.kernel.org/all/[email protected]/
- New commit: Free attached pasid domains on release_device() call

Changes in v4:
- Fix build warning and error on patch 07. The error was introduced during a v1->v2 rebase and hidden by patch 09 which removed the offending line.
- Link to v3: https://lore.kernel.org/all/[email protected]/

Changes in v3:
- Dropped the bulk of the SVA refactoring to re-work as a follow-up series.
- Reworded cover letter to omit dropped changes.
- Rebased on 6.4 tip
- Link to v2: https://lore.kernel.org/all/[email protected]/

Changes in v2:
- Reworded cover letter and commits based on v1 feedback.
- Split and reworked iommu/arm-smmu-v3: Move cdtable to arm_smmu_master
- Added SVA clean-up and refactor.
- A few other small bug fixes and cosmetics.
- Link to v1: https://lore.kernel.org/all/[email protected]/

Michael Shavit (6):
iommu/arm-smmu-v3: Simplify arm_smmu_enable_ats iommu/arm-smmu-v3: Keep track of attached ssids iommu/arm-smmu-v3: Add helper for atc invalidation iommu/arm-smmu-v3: Implement set_dev_pasid iommu/arm-smmu-v3: Free pasid domains on iommu release iommu/arm-smmu-v3: Cleanup arm_smmu_domain_finalise

 .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c   |  28 +-
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c   | 283 ++++++++++++++----
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h   |  31 +-
 3 files changed, 267 insertions(+), 75 deletions(-)

base-commit: 5d0c230f1de8c7515b6567d9afba1f196fb4e2f4
prerequisite-patch-id: c8d21ff19c2c1dd18799a6b83f483add654d187e
prerequisite-patch-id: bdeb88498393e7049fd22cfc24d2b7674e81bb85
prerequisite-patch-id: b84be729e187aa2d67a7f90ec396e2b878c76243
prerequisite-patch-id: 0ee7da8eaae46e2f8a0a791808f421025e148d79
prerequisite-patch-id: 2d80d99964059ecb31065ec4954130c817b9046c
prerequisite-patch-id: 49910462ec68b834c6af18ae9c58de25982e2752
prerequisite-patch-id: 1daf192523b0b7ed24a670b47ad07366aca6d26d
prerequisite-patch-id: 96101f0f4fd95cdb442cfe0881d80c3a61a93716

Signature · 1 line
2.41.0.585.gd2178a4bd4-goog