Skip to content

ptp .adjphase cleanups

Rahul Rameshbabu netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 3 repliesApplied 9/9
  2. v29 patches 11 repliesSuperseded
  3. v19 patches 14 repliesSuperseded

v3->v2 from the cover letter

* Add information about returning -ERANGE instead of clamping out-of-range offsets for driver implementations of .adjphase that previously clamped out-of-range offsets.

Patches in v3 All 9 applied

#Subject and filesSizeRepliesApplied
1/9ptp: Clarify ptp_clock_info .adjphase expects an internal servo to be usedDocumentation/driver-api/ptp.rst include/linux/ptp_clock_kernel.h+20 -20 repliesApplied
2/9docs: ptp.rst: Add information about NVIDIA Mellanox devicesDocumentation/driver-api/ptp.rst+13 -00 repliesApplied
3/9testptp: Remove magic numbers related to nanosecond to second conversiontools/testing/selftests/ptp/testptp.c+2 -20 repliesApplied
4/9testptp: Add support for testing ptp_clock_info .adjphase callbacktools/testing/selftests/ptp/testptp.c+18 -10 repliesApplied
5/9ptp: Add .getmaxphase callback to ptp_clock_infodrivers/ptp/ptp_chardev.c drivers/ptp/ptp_clock.c drivers/ptp/ptp_sysfs.c +3 more+31 -42 repliesApplied
6/9net/mlx5: Add .getmaxphase ptp_clock_info callbackdrivers/net/ethernet/mellanox/mlx5/core/lib/clock.c+15 -160 repliesApplied
7/9ptp: ptp_clockmatrix: Add .getmaxphase ptp_clock_info callbackdrivers/ptp/ptp_clockmatrix.c drivers/ptp/ptp_clockmatrix.h+18 -200 repliesApplied
8/9ptp: idt82p33: Add .getmaxphase ptp_clock_info callbackdrivers/ptp/ptp_idt82p33.c drivers/ptp/ptp_idt82p33.h+11 -110 repliesApplied
9/9ptp: ocp: Add .getmaxphase ptp_clock_info callbackdrivers/ptp/ptp_ocp.c+7 -00 repliesApplied

Reviews trailers per patch

7 of 9 patches have a Reviewed-by or Acked-by.

PatchRichard CochranVadim Fedorenko
1/9A-b
2/9A-b
3/9A-b
4/9A-b
5/9A-b
6/9A-b
7/9
8/9
9/9A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/9] ptp .adjphase cleanups

The goal of this patch series is to improve documentation of .adjphase, add a new callback .getmaxphase to enable advertising the max phase offset a device PHC can support, and support invoking .adjphase from the testptp kselftest.

Changes:
v3->v2:
* Add information about returning -ERANGE instead of clamping out-of-range offsets for driver implementations of .adjphase that previously clamped out-of-range offsets.

v2->v1:
* Removes arbitrary rule that the PHC servo must restore the frequency to the value used in the last .adjfine call if any other PHC operation is used after a .adjphase operation.
* Removes a macro introduced in v1 for adding PTP sysfs device attribute nodes using a callback for populating the data.

Cc Jakub Kicinski <[email protected]>
Cc Richard Cochran <[email protected]>

Rahul Rameshbabu (9):
ptp: Clarify ptp_clock_info .adjphase expects an internal servo to be
used
docs: ptp.rst: Add information about NVIDIA Mellanox devices
testptp: Remove magic numbers related to nanosecond to second
conversion
testptp: Add support for testing ptp_clock_info .adjphase callback
ptp: Add .getmaxphase callback to ptp_clock_info
net/mlx5: Add .getmaxphase ptp_clock_info callback
ptp: ptp_clockmatrix: Add .getmaxphase ptp_clock_info callback
ptp: idt82p33: Add .getmaxphase ptp_clock_info callback
ptp: ocp: Add .getmaxphase ptp_clock_info callback

 Documentation/driver-api/ptp.rst              | 29 +++++++++++++++
 .../ethernet/mellanox/mlx5/core/lib/clock.c   | 31 ++++++++--------
 drivers/ptp/ptp_chardev.c                     |  5 ++-
 drivers/ptp/ptp_clock.c                       |  4 +++
 drivers/ptp/ptp_clockmatrix.c                 | 36 +++++++++----------
 drivers/ptp/ptp_clockmatrix.h                 |  2 +-
 drivers/ptp/ptp_idt82p33.c                    | 18 +++++-----
 drivers/ptp/ptp_idt82p33.h                    |  4 +--
 drivers/ptp/ptp_ocp.c                         |  7 ++++
 drivers/ptp/ptp_sysfs.c                       | 12 +++++++
 include/linux/ptp_clock_kernel.h              | 11 ++++--
 include/uapi/linux/ptp_clock.h                |  3 +-
 tools/testing/selftests/ptp/testptp.c         | 29 ++++++++++++---
 13 files changed, 135 insertions(+), 56 deletions(-)
Signature · 1 line
2.40.1