Skip to content

vhost-user-gpu get_edid feature

Erico Nunes qemu-devel 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 0 repliesNew
  2. v34 patches 2 repliesSuperseded
  3. v24 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches4 repliesSuperseded

Changes in v4 from the cover letter

- Remove unused fd code on patch 4/4

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4virtio-gpu: refactor generate_edid function to virtio_gpu_basehw/display/virtio-gpu-base.c hw/display/virtio-gpu.c include/hw/virtio/virtio-gpu.h+20 -190 replies
2/4docs: vhost-user-gpu: add protocol changes for EDIDdocs/interop/vhost-user-gpu.rst+25 -30 replies
3/4contrib/vhost-user-gpu: implement get_edid featurecontrib/vhost-user-gpu/vhost-user-gpu.c contrib/vhost-user-gpu/virgl.c contrib/vhost-user-gpu/vugpu.h+81 -60 replies
4/4vhost-user-gpu: implement get_edid frontend featurehw/display/vhost-user-gpu.c+32 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMarc-André Lureau
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] vhost-user-gpu get_edid feature

This adds support to the virtio-gpu get_edid command in qemu as the frontend as well as the vhost-user-gpu implementation in contrib/. So far, qemu has been outputting the following message:
EDID requested but the backend doesn't support it.
when using that implementation.

This is tested with vhost-user-gpu, the dbus ui backend and the monitor-edid application, which now shows complete "QEMU Monitor" edid data.

The VHOST_USER_GPU_PROTOCOL_F_EDID protocol feature is required if the frontend sets the VIRTIO_GPU_F_EDID virtio-gpu feature. If the frontend sets the virtio-gpu feature but does not support the protocol feature, the backend will abort with an error.

v3 -> v4:
- Remove unused fd code on patch 4/4

v2 -> v3:
- Fixed review comments from v2. Missing struct documentation and setting feature bits to be compatible with the frontend.

Erico Nunes (4):
virtio-gpu: refactor generate_edid function to virtio_gpu_base
docs: vhost-user-gpu: add protocol changes for EDID contrib/vhost-user-gpu: implement get_edid feature
vhost-user-gpu: implement get_edid frontend feature

 contrib/vhost-user-gpu/vhost-user-gpu.c | 73 +++++++++++++++++++++++--
 contrib/vhost-user-gpu/virgl.c          |  3 +
 contrib/vhost-user-gpu/vugpu.h          | 11 ++++
 docs/interop/vhost-user-gpu.rst         | 28 +++++++++-
 hw/display/vhost-user-gpu.c             | 32 +++++++++++
 hw/display/virtio-gpu-base.c            | 17 ++++++
 hw/display/virtio-gpu.c                 | 20 +------
 include/hw/virtio/virtio-gpu.h          |  2 +
 8 files changed, 158 insertions(+), 28 deletions(-)
Signature · 1 line
2.40.1