Skip to content

drm/fbdev: Remove DRM's helpers for fbdev I/O

Thomas Zimmermann amd-gfx dri-devel intel-gfx linux-arm-kernel linux-arm-msm linux-samsung-soc linux-tegra 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 2/213 patches 1 replyIn review
  2. v5 posting 1/213 patches 6 repliesSuperseded
  3. v413 patches 17 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v312 patches3 repliesSuperseded
v212 patches10 repliesSuperseded
v111 patches5 repliesSuperseded

Changes in v5 from the cover letter

* fix whitespace errors (Jingfeng)
* move msm patch to later position make it build

Patches in v5 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13fbdev: Add Kconfig options to select different fb_ops helpersdrivers/video/fbdev/Kconfig+21 -00 replies
2/13fbdev: Add initializer macros for struct fb_opsinclude/linux/fb.h+112 -00 replies
3/13drm/armada: Use regular fbdev I/O helpersdrivers/gpu/drm/armada/Kconfig drivers/gpu/drm/armada/armada_fbdev.c+3 -50 replies
4/13drm/exynos: Use regular fbdev I/O helpersdrivers/gpu/drm/exynos/Kconfig drivers/gpu/drm/exynos/exynos_drm_fbdev.c+5 -50 replies
5/13drm/gma500: Use regular fbdev I/O helpersdrivers/gpu/drm/gma500/Kconfig drivers/gpu/drm/gma500/fbdev.c+4 -50 replies
6/13drm/radeon: Use regular fbdev I/O helpersdrivers/gpu/drm/radeon/Kconfig drivers/gpu/drm/radeon/radeon_fbdev.c+4 -60 replies
7/13drm/fbdev-dma: Use regular fbdev I/O helpersdrivers/gpu/drm/Kconfig drivers/gpu/drm/drm_fbdev_dma.c+6 -60 replies
8/13drm/omapdrm: Use regular fbdev I/O helpersdrivers/gpu/drm/omapdrm/Kconfig drivers/gpu/drm/omapdrm/omap_fbdev.c+4 -80 replies
9/13drm/tegra: Use regular fbdev I/O helpersdrivers/gpu/drm/tegra/Kconfig drivers/gpu/drm/tegra/fbdev.c+4 -51 reply
10/13drm/fb-helper: Export helpers for marking damage areasdrivers/gpu/drm/drm_fb_helper.c include/drm/drm_fb_helper.h+25 -00 replies
11/13drm/msm: Use regular fbdev I/O helpersdrivers/gpu/drm/msm/Kconfig drivers/gpu/drm/msm/msm_fbdev.c+9 -90 replies
12/13drm/fbdev-generic: Implement dedicated fbdev I/O helpersdrivers/gpu/drm/Kconfig drivers/gpu/drm/drm_fb_helper.c drivers/gpu/drm/drm_fbdev_generic.c +1 more+6 -1590 replies
13/13drm/i915: Implement dedicated fbdev I/O helpersdrivers/gpu/drm/Kconfig drivers/gpu/drm/drm_fb_helper.c drivers/gpu/drm/i915/Kconfig +2 more+9 -1550 replies

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchSui JingfengSam RavnborgAlex DeucherDmitry BaryshkovThierry Reding
1/13R-b R-b
2/13R-b
3/13A-b
4/13A-b
5/13A-b
6/13A-b A-b
7/13A-b
8/13A-b
9/13A-b A-b
10/13A-b
11/13A-b R-b
12/13T-b R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/13] drm/fbdev: Remove DRM's helpers for fbdev I/O

DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() and fb_sys_() helpers. The DRM functions don't provide any additional functionality for most DRM drivers. So remove them and call the fbdev I/O helpers directly.

The DRM fbdev I/O wrappers were originally added because <linux/fb.h> does not protect its content with CONFIG_FB. DRM fbdev emulation did not build if the config option had been disabled. This has been fixed. For fbdev-generic and i915, the wrappers added support for damage handling. But this is better handled within the two callers, as each is special in its damage handling.

Patch 1 adds several internal Kconfig options that DRM drivers (and possibly other fbdev code) will use to select the correct set of I/O helpers. Patch 2 adds initializers for struct fb_ops and generator macros for the callback functions. These macros will simplify drivers. This patchset applies the new options and macros to DRM fbdev emulation, but regular fbdev drivers can use them as well.

Patches 3 to 9 replace the DRM wrappers in a number of fbdev emulations. Patch 10 exports two helpers for damage handling. Patches 11 to 13 update msm, fbdev-generic and i915 with the help of the exported functions. The patches also remove DRM's fbdev I/O helpers, which are now unused.

DRM's fbdev helpers had to select fbdev I/O helpers for I/O and for system memory. Each fbdev emulation now selects the correct helpers for itself. Depending on the selected DRM drivers, kernel builds will now only contain the necessary fbdev I/O helpers and might be slightly smaller in size.

v5:
* fix whitespace errors (Jingfeng)
* move msm patch to later position make it build
v4:
* use initializer and generator macros for struct fb_ops
* partially support damage handling in msm (Dmitri)
v3:
* fix Kconfig options (Jingfeng)
* minimize changes to exynos (Sam)
v2:
* simplify Kconfig handling (Sam)

Thomas Zimmermann (13):
fbdev: Add Kconfig options to select different fb_ops helpers
fbdev: Add initializer macros for struct fb_ops drm/armada: Use regular fbdev I/O helpers drm/exynos: Use regular fbdev I/O helpers drm/gma500: Use regular fbdev I/O helpers drm/radeon: Use regular fbdev I/O helpers drm/fbdev-dma: Use regular fbdev I/O helpers drm/omapdrm: Use regular fbdev I/O helpers drm/tegra: Use regular fbdev I/O helpers drm/fb-helper: Export helpers for marking damage areas drm/msm: Use regular fbdev I/O helpers drm/fbdev-generic: Implement dedicated fbdev I/O helpers drm/i915: Implement dedicated fbdev I/O helpers

 drivers/gpu/drm/Kconfig                    |  10 +-
 drivers/gpu/drm/armada/Kconfig             |   1 +
 drivers/gpu/drm/armada/armada_fbdev.c      |   7 +-
 drivers/gpu/drm/drm_fb_helper.c            | 236 ++-------------------
 drivers/gpu/drm/drm_fbdev_dma.c            |  11 +-
 drivers/gpu/drm/drm_fbdev_generic.c        |  11 +-
 drivers/gpu/drm/exynos/Kconfig             |   1 +
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c  |   9 +-
 drivers/gpu/drm/gma500/Kconfig             |   1 +
 drivers/gpu/drm/gma500/fbdev.c             |   8 +-
 drivers/gpu/drm/i915/Kconfig               |   1 +
 drivers/gpu/drm/i915/display/intel_fbdev.c |  14 +-
 drivers/gpu/drm/msm/Kconfig                |   1 +
 drivers/gpu/drm/msm/msm_fbdev.c            |  17 +-
 drivers/gpu/drm/omapdrm/Kconfig            |   1 +
 drivers/gpu/drm/omapdrm/omap_fbdev.c       |  11 +-
 drivers/gpu/drm/radeon/Kconfig             |   1 +
 drivers/gpu/drm/radeon/radeon_fbdev.c      |   9 +-
 drivers/gpu/drm/tegra/Kconfig              |   1 +
 drivers/gpu/drm/tegra/fbdev.c              |   8 +-
 drivers/video/fbdev/Kconfig                |  21 ++
 include/drm/drm_fb_helper.h                |  83 +-------
 include/linux/fb.h                         | 112 ++++++++++
 23 files changed, 212 insertions(+), 363 deletions(-)

base-commit: cf59b48ea3c0c0075d7c4e8538177d38999da7b0
prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: cbc453ee02fae02af22fbfdce56ab732c7a88c36

Signature · 1 line
2.40.1