Skip to content

Follow-up "Fix excessive CPU usage during compaction"

Mel Gorman linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 15 repliesIn review 3 of 4 applied

Patches in v1 3 of 4 applied

#Subject and filesSizeRepliesApplied
1/4mm: compaction: Ensure rescanning only happens on partially scanned pageblocksmm/compaction.c+3 -21 replyApplied
2/4mm: compaction: Only force pageblock scan completion when skip hints are obeyedmm/compaction.c+3 -21 replyApplied
3/4mm: compaction: Update pageblock skip when first migration candidate is not at the startmm/compaction.c+5 -109 replies
4/4Revert "Revert "mm/compaction: fix set skip in fast_find_migrateblock""mm/compaction.c+0 -11 replyApplied

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchBaolin WangVlastimil Babka
SeriesT-b
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Follow-up "Fix excessive CPU usage during compaction"

The series "Fix excessive CPU usage during compaction" [1] attempted to fix a bug [2] but Vlastimil noted that the fix was incomplete [3]. While the series was merged, fast_find_migrateblock was still disabled. This series should fix the corner cases and allow 95e7a450b819 ("Revert "mm/compaction: fix set skip in fast_find_migrateblock"") to be safely reverted. Details on how many pageblocks are rescanned are in the changelog of the last patch.

[1] https://lore.kernel.org/r/[email protected]
[2] https://bugzilla.suse.com/show_bug.cgi?id=1206848
[3] https://lore.kernel.org/r/[email protected]

 mm/compaction.c | 24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)
Signature · 1 line
2.35.3