Skip to content

gputop/intel_gpu_top: Move name to be the last field

Tvrtko Ursulin igt-dev intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2gputop: Move client name lasttools/gputop.c+9 -101 reply
2/2intel_gpu_top: Move client name lasttools/intel_gpu_top.c+9 -102 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKamil Konieczny
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [igt-dev] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field

From: Tvrtko Ursulin <[email protected]>

Rob,

I thought maybe when you add memory stats the same field order like top(1) would feel more natural? That is client name comes last and is left justified. All other stats then come in the middle, between PID and NAME.

DRM minor 0

    PID     render         copy         video     video-enhance  NAME
   2704 |▌           ||            ||            ||            | kwin_x11
   2734 |▏           ||            ||            ||            | plasmashell
   3932 |            ||            ||            ||            | krunner
   4414 |            ||            ||            ||            | xdg-desktop-por
1999477 |            ||            ||            ||            | firefox
2162094 |            ||            ||            ||            | thunderbir

intel-gpu-top: Intel Alderlake_s (Gen12) @ /dev/dri/card0 - 15/ 15 MHz
99% RC6; 0.01/ 5.46 W; 34 irqs/s

ENGINES BUSY MI_SEMA MI_WAIT
Render/3D 1.31% |▌ | 0% 0%
Blitter 0.00% | | 0% 0%
Video 0.00% | | 0% 0%
VideoEnhance 0.00% | | 0% 0%

PID Render/3D Blitter Video VideoEnhance NAME

   2734 |▏           ||            ||            ||            | plasmashell
   2704 |▏           ||            ||            ||            | kwin_x11
   1837 |▏           ||            ||            ||            | Xorg
3429732 |            ||            ||            ||            | kwrite
2162094 |            ||            ||            ||            | thunderbird
Cc Rob Clark <[email protected]>

Tvrtko Ursulin (2):
gputop: Move client name last
intel_gpu_top: Move client name last

 tools/gputop.c        | 19 +++++++++----------
 tools/intel_gpu_top.c | 19 +++++++++----------
 2 files changed, 18 insertions(+), 20 deletions(-)
Signature · 1 line
2.37.2