Skip to content

ethdev: modify field API for multiple headers

Michael Baum dpdk-dev 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 2 repliesIn review
  2. v45 patches 0 repliesSuperseded
  3. v35 patches 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches6 repliesSuperseded
v17 patches2 repliesSuperseded

Changes in v5 from the cover letter

- Fix location of level validation.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5doc: fix blank lines in modify field action descriptiondoc/guides/prog_guide/rte_flow.rst+9 -60 replies
2/5doc: fix blank line in asynchronous operations descriptiondoc/guides/prog_guide/rte_flow.rst+1 -00 replies
3/5doc: fix wrong indentation in RSS action descriptiondoc/guides/prog_guide/rte_flow.rst+2 -20 replies
4/5ethdev: add GENEVE TLV option modification supportapp/test-pmd/cmdline_flow.c doc/guides/prog_guide/rte_flow.rst doc/guides/rel_notes/release_23_07.rst +2 more+131 -130 replies
5/5ethdev: add MPLS header modification supportapp/test-pmd/cmdline_flow.c doc/guides/prog_guide/rte_flow.rst doc/guides/rel_notes/release_23_07.rst +5 more+199 -901 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchOri Kam
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/5] ethdev: modify field API for multiple headers

This patch-set extend the modify field action API to support both multiple MPLS and GENEVE option headers.

In current API, the header type is provided by rte_flow_field_id enumeration and the encapsulation level (inner/outer/tunnel) is specified by data.level field.
However, there is no way to specify header inside encapsulation level.

For example, for this packet:

eth / mpls / mpls / mpls / ipv4 / udp
the both second and third MPLS headers cannot be modified using this API.

RFC:
https://patchwork.dpdk.org/project/dpdk/cover/[email protected]/

v2:
- Change "sub_level" name to "tag_index".
- Squash PMD changes into API changes patch.
- Remove PMD private patch from the patch-set.

v3:
- Add TAG array API change to release notes.
- Improve comment and documentation.

v4:
- Add "Acked-by" labels.
- Add PMD adjustment for TAG array API change.

v5:
- Fix location of level validation.

Michael Baum (5):
doc: fix blank lines in modify field action description
doc: fix blank line in asynchronous operations description
doc: fix wrong indentation in RSS action description
ethdev: add GENEVE TLV option modification support
ethdev: add MPLS header modification support

 app/test-pmd/cmdline_flow.c            |  70 +++++++++++++++-
 doc/guides/prog_guide/rte_flow.rst     |  59 ++++++++++---
 doc/guides/rel_notes/release_23_07.rst |   7 ++
 drivers/net/mlx5/mlx5_flow.c           |  34 ++++++++
 drivers/net/mlx5/mlx5_flow.h           |  23 ++++++
 drivers/net/mlx5/mlx5_flow_dv.c        | 110 +++++++++++--------------
 drivers/net/mlx5/mlx5_flow_hw.c        |  43 ++++++----
 lib/ethdev/rte_flow.h                  |  73 +++++++++++++++-
 8 files changed, 325 insertions(+), 94 deletions(-)
Signature · 1 line
2.25.1