arm64: address -Wmissing-prototype warnings
Status from this message: Applied to arm64 (for-next/missing-proto-warn), thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | arm64: xor-neon: mark xor_arm64_neon_*() staticarch/ | +4 | 0 replies | |
| 2/15 | arm64: add scs_patch_vmlinux prototypearch/ | +1 | 0 replies | |
| 3/15 | arm64: avoid prototype warnings for syscallsarch/ arch/ | +6 | 0 replies | |
| 4/15 | arm64: move cpu_suspend_set_dbg_restorer() prototype to headerarch/ arch/ | +8 | 0 replies | |
| 5/15 | arm64: spectre: provide prototypes for internal functionsarch/ | +16 | 0 replies | |
| 6/15 | arm64: kvm: add prototypes for functions called in asmarch/ | +18 | 0 replies | |
| 7/15 | arm64: cpuidle: fix #ifdef for acpi functionsarch/ | +1 | 0 replies | |
| 8/15 | arm64: efi: add efi_handle_corrupted_x18 prototypearch/ | +2 | 0 replies | |
| 9/15 | arm64: hide unused is_valid_bugaddr()arch/ | +2 | 0 replies | |
| 10/15 | arm64: module-plts: inline linux/moduleloader.harch/ | +1 | 0 replies | |
| 11/15 | arm64: flush: include linux/libnvdimm.harch/ | +1 | 0 replies | |
| 12/15 | arm64: kaslr: add kaslr_early_init() declarationarch/ | +2 | 0 replies | |
| 13/15 | arm64: signal: include asm/exception.harch/ | +1 | 0 replies | |
| 14/15 | arm64: move early_brk64 prototype to headerarch/ arch/ | +2 | 0 replies | |
| 15/15 | arm64: add alt_cb_patch_nops prototypearch/ | +3 | 0 replies |
Reviews trailers per patch
None of the 15 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Ard Biesheuvel | Kees Cook |
|---|---|---|
| Series | A-b | R-b |
| 1/15 | ||
| 2/15 | ||
| 3/15 | ||
| 4/15 | ||
| 5/15 | ||
| 6/15 | ||
| 7/15 | ||
| 8/15 | ||
| 9/15 | ||
| 10/15 | ||
| 11/15 | ||
| 12/15 | ||
| 13/15 | ||
| 14/15 | ||
| 15/15 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/15] arm64: address -Wmissing-prototype warnings
From: Arnd Bergmann <[email protected]>
This addresses all arm64 specific protype warnings. As with the arm32 patches, the majority of them should be straightforward, either adding an #include statement to get the right header, or ensuring that an unused global function is left out of the build when the prototype is hidden.
The ones that are a bit awkward are those that just add a prototype to shut up the warning, but the prototypes are never used for calling the function because the only caller is in assembler code. I tried to come up with other ways to shut up the compiler, and ideally this would be triggered by the 'asmlinkage' keyword as Ard suggested in the past, but I could not come up with a way to do this.
All of the warnings have to be addressed in some form before the warning can be enabled by default.
Arnd
Arnd Bergmann (15):
arm64: xor-neon: mark xor_arm64_neon_*() static
arm64: add scs_patch_vmlinux prototype
arm64: avoid prototype warnings for syscalls
arm64: move cpu_suspend_set_dbg_restorer() prototype to header
arm64: spectre: provide prototypes for internal functions
arm64: kvm: add prototypes for functions called in asm
arm64: cpuidle: fix #ifdef for acpi functions
arm64: efi: add efi_handle_corrupted_x18 prototype
arm64: hide unused is_valid_bugaddr()
arm64: module-plts: inline linux/moduleloader.h
arm64: flush: include linux/libnvdimm.h
arm64: kaslr: add kaslr_early_init() declaration
arm64: signal: include asm/exception.h
arm64: move early_brk64 prototype to header
arm64: add alt_cb_patch_nops prototype
arch/arm64/include/asm/alternative.h | 3 +++ arch/arm64/include/asm/archrandom.h | 2 ++ arch/arm64/include/asm/compat.h | 2 ++ arch/arm64/include/asm/efi.h | 2 ++ arch/arm64/include/asm/hw_breakpoint.h | 8 ++++++++ arch/arm64/include/asm/kvm_asm.h | 18 ++++++++++++++++++ arch/arm64/include/asm/scs.h | 1 + arch/arm64/include/asm/spectre.h | 16 ++++++++++++++++ arch/arm64/include/asm/syscall_wrapper.h | 4 ++++ arch/arm64/include/asm/traps.h | 2 ++ arch/arm64/kernel/cpuidle.c | 2 +- arch/arm64/kernel/hw_breakpoint.c | 8 -------- arch/arm64/kernel/module-plts.c | 1 + arch/arm64/kernel/signal.c | 1 + arch/arm64/kernel/traps.c | 3 ++- arch/arm64/lib/xor-neon.c | 8 ++++---- arch/arm64/mm/fault.c | 3 --- arch/arm64/mm/flush.c | 1 + 18 files changed, 68 insertions(+), 17 deletions(-)
Signature · 19 lines
2.39.2 Cc: Catalin Marinas <[email protected]> Cc: Will Deacon <[email protected]> Cc: Ard Biesheuvel <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Marc Zyngier <[email protected]> Cc: Oliver Upton <[email protected]> Cc: James Morse <[email protected]> Cc: Suzuki K Poulose <[email protected]> Cc: Zenghui Yu <[email protected]> Cc: Arnd Bergmann <[email protected]> Cc: Anshuman Khandual <[email protected]> Cc: Kees Cook <[email protected]> Cc: Suren Baghdasaryan <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected]