Skip to content

RK3588 ADC support

Shreeya Patel linux-arm-kernel linux-devicetree linux-iio linux-rockchip lkml 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 6 repliesApplied
  2. v28 patches 5 repliesSuperseded
  3. v17 patches 10 repliesSuperseded

Changes in v3 from the cover letter

- Add bitfield.h header file in patch 2.
- Add a Reviewed-by tag in patch 2.
- Do not remove clock enabling and disabling from the suspend and resume functions respectively in patch 3

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/8iio: adc: rockchip_saradc: Add callback functionsdrivers/iio/adc/rockchip_saradc.c+52 -120 replies
2/8iio: adc: rockchip_saradc: Add support for RK3588drivers/iio/adc/rockchip_saradc.c+70 -03 replies
3/8iio: adc: rockchip_saradc: Make use of devm_clk_get_enableddrivers/iio/adc/rockchip_saradc.c+8 -480 replies
4/8iio: adc: rockchip_saradc: Use of_device_get_match_datadrivers/iio/adc/rockchip_saradc.c+4 -40 replies
5/8iio: adc: rockchip_saradc: Match alignment with open parenthesisdrivers/iio/adc/rockchip_saradc.c+2 -30 replies
6/8iio: adc: rockchip_saradc: Use dev_err_probedrivers/iio/adc/rockchip_saradc.c+20 -250 replies
7/8arm64: dts: rockchip: Add DT node for ADC support in RK3588arch/arm64/boot/dts/rockchip/rk3588s.dtsi+12 -00 replies
8/8dt-bindings: iio: adc: Add rockchip,rk3588-saradc stringDocumentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml+1 -00 replies

Reviews trailers per patch

4 of 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAngeloGioacchino Del RegnoKrzysztof KozlowskiAndy Shevchenko
SeriesR-b
1/8
2/8R-b
3/8
4/8R-b
5/8R-b
6/8
7/8
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/8] RK3588 ADC support

This patch series adds ADC support for RK3588 and updates the DT bindings for the same.

To test ADC support on Rock 5B board, a voltage divider circuit was created using the gpio pin 22 ( SARADC_IN4 ) and few more tests were ran for testing the buffer and trigger support using the iio_generic_buffer tool.

Changes in v3
- Add bitfield.h header file in patch 2.
- Add a Reviewed-by tag in patch 2.
- Do not remove clock enabling and disabling from the suspend and resume functions respectively in patch 3

Changes in v2
- Add from address in patches 1 and 2.
- Create separate patches for adding new device support and changes to the old device code.
- Make use of FIELD_PREP in patch 2.
- Move the enablement of clocks at it's original position in patch 3
- Add Reviewed-by tag in patches 4 and 5.
- Add an Acked-by tag in patch 8.

Shreeya Patel (8):
iio: adc: rockchip_saradc: Add callback functions
iio: adc: rockchip_saradc: Add support for RK3588
iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled
iio: adc: rockchip_saradc: Use of_device_get_match_data
iio: adc: rockchip_saradc: Match alignment with open parenthesis
iio: adc: rockchip_saradc: Use dev_err_probe
arm64: dts: rockchip: Add DT node for ADC support in RK3588
dt-bindings: iio: adc: Add rockchip,rk3588-saradc string

 .../bindings/iio/adc/rockchip-saradc.yaml     |   1 +
 arch/arm64/boot/dts/rockchip/rk3588s.dtsi     |  12 +
 drivers/iio/adc/rockchip_saradc.c             | 246 +++++++++++-------
 3 files changed, 168 insertions(+), 91 deletions(-)
Signature · 1 line
2.30.2