Skip to content

ice: Implement support for SRIOV + LAG

Dave Ertman intel-wired-lan llvm oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v6 Latest10 patches 1 replyIn review

Changes in v6 from the cover letter

checkpatch hit one-line if block that changes to multi-line on later
patch
rebase on dev-queue and remove 1st patch that was accepted individually

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ice: Correctly initialize queue context valuesdrivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_sched.c+19 -50 replies
2/10ice: Add driver support for firmware changes for LAGdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_common.c +5 more+59 -281 reply
3/10ice: changes to the interface with the HW and FW for SRIOV_VF+LAGdrivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_common.h +4 more+212 -290 replies
4/10ice: implement lag netdev event handlerdrivers/net/ethernet/intel/ice/ice_lag.c drivers/net/ethernet/intel/ice/ice_lag.h drivers/net/ethernet/intel/ice/ice_virtchnl.c+144 -140 replies
5/10ice: process events created by lag netdev event handlerdrivers/net/ethernet/intel/ice/ice_lag.c drivers/net/ethernet/intel/ice/ice_switch.c drivers/net/ethernet/intel/ice/ice_switch.h+475 -730 replies
6/10ice: Flesh out implementation of support for SRIOV on bonded interfacedrivers/net/ethernet/intel/ice/ice_lag.c+848 -30 replies
7/10ice: support non-standard teardown of bond interfacedrivers/net/ethernet/intel/ice/ice_lag.c+40 -70 replies
8/10ice: enforce interface eligibility and add messaging for SRIOV LAGdrivers/net/ethernet/intel/ice/ice_lag.c+83 -50 replies
9/10ice: enforce no DCB config changing when in bonddrivers/net/ethernet/intel/ice/ice_dcb_nl.c+50 -00 replies
10/10ice: update reset path for SRIOV LAG supportdrivers/net/ethernet/intel/ice/ice_lag.c drivers/net/ethernet/intel/ice/ice_lag.h drivers/net/ethernet/intel/ice/ice_main.c+300 -40 replies

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by.

PatchRafal Romanowski
1/10
2/10T-b
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [Intel-wired-lan] [PATCH iwl-next v6 00/10] ice: Implement support for SRIOV + LAG

Implement support for SRIOV VF's on interfaces that are in an aggregate interface.

The first interface added into the aggregate will be flagged as the primary interface, and this primary interface will be responsible for managing the VF's resources. VF's created on the primary are the only VFs that will be supported on the aggregate. Only Active-Backup mode is supported and only aggregates whose primary interface is in switchdev mode will be supported.

Additional restrictions on what interfaces can be added to the aggregate and still support SRIOV VFs are:
- interfaces must all be on the same physical NIC
- all interfaces must have the same QoS settings
- interfaces must have the FW LLDP agent disabled
- only the primary interface is to be put into switchdev mode
- no more than two interfaces in the aggregate

Changes since v1:
change first patch title
added cover letter

Changes since v2:
fixed attrib for one patch
typos and header format
broke dflt VSI fltr code to a functino for re-use

Changes since v3:
made ice_lag_find_hw_by_lport a static function
fixed a cpu_to_le16 issue
during VF queue recfg, skip unconfigured queues instead of stopping correctly locate resources to reclaim nodes on UNREGISTER event

Chaqnges since v4:
Remove pf_rule boolean form ice_lag struct
Refactor creation/remove of default VSI filter into function Correctly reclaim sched nodes on driver unload added err message when failing filter creation in reset path return a u16 for queue count
eliminate unused variables
typos in comments
Adjust some patch content to avoid "defined by not used" from
defining things before being used
Rebased on latest upstream

Changes since v5:
checkpatch hit one-line if block that changes to multi-line on later
patch
rebase on dev-queue and remove 1st patch that was accepted individually

Dave Ertman (9):
ice: Add driver support for firmware changes for LAG
ice: changes to the interface with the HW and FW for SRIOV_VF+LAG
ice: implement lag netdev event handler
ice: process events created by lag netdev event handler
ice: Flesh out implementation of support for SRIOV on bonded interface
ice: support non-standard teardown of bond interface
ice: enforce interface eligibility and add messaging for SRIOV LAG
ice: enforce no DCB config changing when in bond
ice: update reset path for SRIOV LAG support

Jacob Keller (1):
ice: Correctly initialize queue context values

 drivers/net/ethernet/intel/ice/ice.h          |    5 +
 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |   53 +-
 drivers/net/ethernet/intel/ice/ice_common.c   |   57 +-
 drivers/net/ethernet/intel/ice/ice_common.h   |    4 +
 drivers/net/ethernet/intel/ice/ice_dcb_nl.c   |   50 +
 drivers/net/ethernet/intel/ice/ice_lag.c      | 1912 ++++++++++++++++-
 drivers/net/ethernet/intel/ice/ice_lag.h      |   34 +-
 drivers/net/ethernet/intel/ice/ice_lib.c      |    2 +-
 drivers/net/ethernet/intel/ice/ice_lib.h      |    1 +
 drivers/net/ethernet/intel/ice/ice_main.c     |   26 +-
 drivers/net/ethernet/intel/ice/ice_sched.c    |   37 +-
 drivers/net/ethernet/intel/ice/ice_sched.h    |   21 +
 drivers/net/ethernet/intel/ice/ice_switch.c   |   89 +-
 drivers/net/ethernet/intel/ice/ice_switch.h   |   29 +
 drivers/net/ethernet/intel/ice/ice_type.h     |    2 +
 drivers/net/ethernet/intel/ice/ice_virtchnl.c |    2 +
 16 files changed, 2193 insertions(+), 131 deletions(-)
Signature · 6 lines
2.40.1

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan