Skip to content

can: kvaser_pciefd: Fixes and improvments

Jimmy Assarsson linux-can 2 versions – Applied

Status from this message: Applied to linux-can-next, fixing the typo while applying:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 2 repliesApplied
  2. v112 patches 3 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/14can: kvaser_pciefd: Remove useless write to interrupt registerdrivers/net/can/kvaser_pciefd.c+2 -70 replies
2/14can: kvaser_pciefd: Remove handler for unused KVASER_PCIEFD_PACK_TYPE_EFRAME_ACKdrivers/net/can/kvaser_pciefd.c+1 -380 replies
3/14can: kvaser_pciefd: Add function to set skb hwtstampsdrivers/net/can/kvaser_pciefd.c+10 -170 replies
4/14can: kvaser_pciefd: Set hardware timestamp on transmitted packetsdrivers/net/can/kvaser_pciefd.c+10 -20 replies
5/14can: kvaser_pciefd: Define unsigned constants with type suffix 'U'drivers/net/can/kvaser_pciefd.c+5 -50 replies
6/14can: kvaser_pciefd: Remove SPI flash parameter read functionalitydrivers/net/can/Kconfig drivers/net/can/kvaser_pciefd.c+5 -2180 replies
7/14can: kvaser_pciefd: Sort includes in alphabetic orderdrivers/net/can/kvaser_pciefd.c+5 -50 replies
8/14can: kvaser_pciefd: Rename device ID definesdrivers/net/can/kvaser_pciefd.c+23 -110 replies
9/14can: kvaser_pciefd: Change return type for kvaser_pciefd_{receive,transmit,set_tx}_irq()drivers/net/can/kvaser_pciefd.c+3 -70 replies
10/14can: kvaser_pciefd: Sort register definitionsdrivers/net/can/kvaser_pciefd.c+110 -1000 replies
11/14can: kvaser_pciefd: Use FIELD_{GET,PREP} and GENMASK where appropriatedrivers/net/can/kvaser_pciefd.c+89 -790 replies
12/14can: kvaser_pciefd: Add len8_dlc supportdrivers/net/can/kvaser_pciefd.c+12 -40 replies
13/14can: kvaser_pciefd: Refactor codedrivers/net/can/kvaser_pciefd.c+87 -1340 replies
14/14can: kvaser_pciefd: Use TX FIFO size read from CAN controllerdrivers/net/can/kvaser_pciefd.c+3 -120 replies

Reviews trailers per patch

None of the 14 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchVincent Mailhol
SeriesR-b
1/14
2/14
3/14
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/14] can: kvaser_pciefd: Fixes and improvments

This patch series contains various non critical fixes and improvments for the kvaser_pciefd driver.

Jimmy Assarsson (14):
can: kvaser_pciefd: Remove useless write to interrupt register
can: kvaser_pciefd: Remove handler for unused
KVASER_PCIEFD_PACK_TYPE_EFRAME_ACK
can: kvaser_pciefd: Add function to set skb hwtstamps
can: kvaser_pciefd: Set hardware timestamp on transmitted packets
can: kvaser_pciefd: Define unsigned constants with type suffix 'U'
can: kvaser_pciefd: Remove SPI flash parameter read functionality
can: kvaser_pciefd: Sort includes in alphabetic order
can: kvaser_pciefd: Rename device ID defines
can: kvaser_pciefd: Change return type for
kvaser_pciefd_{receive,transmit,set_tx}_irq()
can: kvaser_pciefd: Sort register definitions
can: kvaser_pciefd: Use FIELD_{GET,PREP} and GENMASK where appropriate
can: kvaser_pciefd: Add len8_dlc support
can: kvaser_pciefd: Refactor code
can: kvaser_pciefd: Use TX FIFO size read from CAN controller

 drivers/net/can/Kconfig         |   3 +-
 drivers/net/can/kvaser_pciefd.c | 955 ++++++++++++--------------------
 2 files changed, 342 insertions(+), 616 deletions(-)
Signature · 7 lines
Changes in v2:
  - Add new patches, to replace opencoded masking+shifting with
    FIELD_{GET,PREP} and GENMASK, suggested by Vincent MAILHOL [1]

[1] https://lore.kernel.org/linux-can/[email protected]/T/#m14c3851e70cfb8c903388e068968a4a379d183e6

2.40.0