Skip to content

Update Xe uAPI in a minimally invasive way

Christopher Snowhill intel-xe 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 16 repliesIn review
  2. v12 patches 6 repliesSuperseded

Changes in v2 from the cover letter

Removed extensions checks where there were none originally. (José) Moved extraneous parentheses to the correct places. (Lucas)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/xe: Add explicit padding to uAPI definitioninclude/uapi/drm/xe_drm.h+33 -10 replies
2/2drm/xe: Validate uAPI padding and reserved fieldsdrivers/gpu/drm/xe/xe_bo.c drivers/gpu/drm/xe/xe_engine.c drivers/gpu/drm/xe/xe_exec.c +6 more+52 -153 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJosé Roberto de SouzaLucas De MarchiChristopher Snowhill
SeriesA-b
1/2R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [Intel-xe] [PATCH v2 0/2] Update Xe uAPI in a minimally invasive way

This series takes off from mlankhorst's attempt to do the same, except instead, it tries to be as minimally invasive to the original uAPI as possible, by only inserting padding where appropriate to ensure all 32-bit members are 32-bit aligned, and all 64-bit members are 64-bit aligned. This should have zero effect on 64-bit hosts versus 64-bit userspace, so existing native software will operate the same with or without the update. The only real change is 32-bit compat support for multilib userspace, which was previously broken.

Also introduces field validation against all of the padding and reserved fields, which must be zero, in a separate commit.

v2:
Removed extensions checks where there were none originally. (José) Moved extraneous parentheses to the correct places. (Lucas)

Christopher Snowhill (2):
drm/xe: Add explicit padding to uAPI definition drm/xe: Validate uAPI padding and reserved fields

 drivers/gpu/drm/xe/xe_bo.c              |  6 +++--
 drivers/gpu/drm/xe/xe_engine.c          | 18 ++++++++++---
 drivers/gpu/drm/xe/xe_exec.c            |  4 ++-
 drivers/gpu/drm/xe/xe_mmio.c            |  3 ++-
 drivers/gpu/drm/xe/xe_query.c           |  3 ++-
 drivers/gpu/drm/xe/xe_sync.c            |  4 ++-
 drivers/gpu/drm/xe/xe_vm.c              | 22 +++++++++++++---
 drivers/gpu/drm/xe/xe_vm_madvise.c      |  4 ++-
 drivers/gpu/drm/xe/xe_wait_user_fence.c |  3 ++-
 include/uapi/drm/xe_drm.h               | 34 ++++++++++++++++++++++++-
 10 files changed, 85 insertions(+), 16 deletions(-)
Signature · 1 line
2.40.1