perf cs-etm: Track exception level
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest5 patches 3 repliesIn review
- v25 patches 3 repliesSuperseded
- v14 patches 24 repliesSuperseded
Changes in v3 from the cover letter
* Rename prev_thread -> prev_packet_thread and prev_el -> prev_packet_el
* Add a comment about tracking the previous packet's thread
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | perf cs-etm: Only track threads instead of PID and TIDstools/ | +38 | 0 replies | |
| 2/5 | perf cs-etm: Use previous thread for branch sample source IPtools/ | +15 | 0 replies | |
| 3/5 | perf cs-etm: Make PID format accessible from struct cs_etm_auxtracetools/ tools/ tools/ | +37 | 0 replies | |
| 4/5 | perf cs-etm: Track exception leveltools/ tools/ tools/ | +68 | 0 replies | |
| 5/5 | perf cs-etm: Add exception level consistency checktools/ tools/ tools/ | +36 | 0 replies |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Suzuki K Poulose | Mike Leach | Leo Yan |
|---|---|---|---|
| 1/5 | A-b | R-b | R-b |
| 2/5 | R-b | ||
| 3/5 | R-b | ||
| 4/5 | R-b | ||
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/5] perf cs-etm: Track exception level
Changes since v2:
* Rename prev_thread -> prev_packet_thread and prev_el -> prev_packet_el
* Add a comment about tracking the previous packet's thread
Changes since v1:
* Always assume host kernel when the trace was captured at EL1 (nVHE)
* Fix EL validation to work with ETMv3
* Add a commit to make PID format accessible from struct cs_etm_auxtrace
======
Some fixes to support an issue reported by Denis Nikitin where decoding trace that contains different EL1 and EL2 kernels can crash or go into an infinite loop because the wrong kernel maps are used for the decode.
This still doesn't support distinguishing guest and host userspace, we'd still have to fix the timestamps and do a bit more work to correlate that. And I've removed PERF_RECORD_MISC_HYPERVISOR as a possible outcome of cs_etm__cpu_mode(). As far as I know this could never have been returned anyway because machine__is_host(machine) was always true due to session.machines.host being hard coded. And I'm not sure of the relevance of the difference between PERF_RECORD_MISC_KERNEL and PERF_RECORD_MISC_HYPERVISOR in this scenario.
The first commit is a tidy up, second fixes a bug that I found when comparing the exception level and thread of branch records, the third is the main fix, and the last commit is some extra error checking.
Applies to acme/perf-tools-next (42713dafc)
James Clark (5):
perf cs-etm: Only track threads instead of PID and TIDs perf cs-etm: Use previous thread for branch sample source IP perf cs-etm: Make PID format accessible from struct cs_etm_auxtrace perf cs-etm: Track exception level
perf cs-etm: Add exception level consistency check
.../perf/util/cs-etm-decoder/cs-etm-decoder.c | 33 +- .../perf/util/cs-etm-decoder/cs-etm-decoder.h | 4 +- tools/perf/util/cs-etm.c | 282 ++++++++++-------- tools/perf/util/cs-etm.h | 13 +- 4 files changed, 184 insertions(+), 148 deletions(-)
Signature · 1 line
2.34.1