Skip to content

ALSA: hda: Adding support for CS35L56 on HDA systems

Richard Fitzgerald alsa-devel lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest11 patches 6 repliesIn review
  2. v412 patches 2 repliesSuperseded
  3. v312 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v212 patches0 repliesSuperseded
v113 patches6 repliesSuperseded

CHANGES SINCE V5 from the cover letter

The series has been rebased onto commit df4167d658d4 ("ASoC: cs35l56: Patch soft registers to defaults"), which removes cs35l56_reread_firmware_registers() and adds cs35l56_set_patch().

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11ASoC: cs35l56: Move shared data into a common data structureinclude/sound/cs35l56.h sound/soc/codecs/cs35l56-i2c.c sound/soc/codecs/cs35l56-sdw.c +4 more+270 -2590 replies
2/11ASoC: cs35l56: Make cs35l56_system_reset() code more genericsound/soc/codecs/cs35l56.c+6 -60 replies
3/11ASoC: cs35l56: Convert utility functions to use common data structuresound/soc/codecs/cs35l56.c+16 -160 replies
4/11ASoC: cs35l56: Move utility functions to shared fileinclude/sound/cs35l56.h sound/soc/codecs/cs35l56-shared.c sound/soc/codecs/cs35l56.c+215 -2030 replies
5/11ASoC: cs35l56: Move runtime suspend/resume to shared libraryinclude/sound/cs35l56.h sound/soc/codecs/cs35l56-sdw.c sound/soc/codecs/cs35l56-shared.c +2 more+126 -1200 replies
6/11ASoC: cs35l56: Move cs_dsp init into shared libraryinclude/sound/cs35l56.h sound/soc/codecs/cs35l56-shared.c sound/soc/codecs/cs35l56.c+18 -130 replies
7/11ASoC: cs35l56: Move part of cs35l56_init() to shared libraryinclude/sound/cs35l56.h sound/soc/codecs/cs35l56-shared.c sound/soc/codecs/cs35l56.c+82 -690 replies
8/11ASoC: cs35l56: Make common function for control port waitinclude/sound/cs35l56.h sound/soc/codecs/cs35l56-shared.c+11 -60 replies
9/11ASoC: cs35l56: Make a common function to shutdown the DSPinclude/sound/cs35l56.h sound/soc/codecs/cs35l56-shared.c sound/soc/codecs/cs35l56.c+28 -160 replies
10/11ALSA: hda: Fix missing header dependenciessound/pci/hda/hda_auto_parser.h sound/pci/hda/hda_generic.h+5 -00 replies
11/11ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifiersound/pci/hda/Kconfig sound/pci/hda/Makefile sound/pci/hda/cs35l56_hda.c +3 more+1217 -00 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchMark BrownTakashi Iwai
1/11A-b
2/11A-b
3/11A-b
4/11A-b
5/11A-b
6/11A-b
7/11A-b
8/11A-b
9/11A-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/11] ALSA: hda: Adding support for CS35L56 on HDA systems

This set of patches adds support for using the CS35L56 boosted smart amplifier on HDA systems. In these systems the CS35L56 audio is routed through a HDA-to-I2S bridge codec.

This doesn't include the changes to the Realtek driver to actually hook up the CS35L56 driver, because we don't yet have the QUIRK IDs to associate it with. But we want to publish the driver now so that it is available for bringing up hardware with the CS35L56.

The first 9 patches are moving code out of the ASoC driver and into the shared library so that it can be shared with the HDA driver.

Patch #10 fixes missing #includes in the HDA headers so that the CS35L56 driver doesn't have to #include headers that it doesn't use.

CHANGES SINCE V5
The series has been rebased onto commit df4167d658d4 ("ASoC: cs35l56: Patch soft registers to defaults"), which removes cs35l56_reread_firmware_registers() and adds cs35l56_set_patch().

Changes are trivial so I have carried forward Mark's and Takashi's acks.

Patch 01:
- Also changes cs35l56_set_patch() argument to new struct cs35l56_base.

Patch 11:
- Remove call to cs35l56_reread_firmware_registers()
- Add call to cs35l56_set_patch() in cs35l56_hda_common_probe()
- Do not add mute_hook to struct hda_component. This was for use with CS8409 as an HDA bridge, but production systems will use Realtek, which has its own mute control.
- Use strscpy() instead of strcpy() in cs35l56_hda_mixer_info()
- Fix missing word in Kconfig option title

Richard Fitzgerald (4):
ASoC: cs35l56: Move runtime suspend/resume to shared library
ASoC: cs35l56: Move cs_dsp init into shared library
ASoC: cs35l56: Move part of cs35l56_init() to shared library
ALSA: hda: Fix missing header dependencies

Simon Trimmer (7):
ASoC: cs35l56: Move shared data into a common data structure
ASoC: cs35l56: Make cs35l56_system_reset() code more generic
ASoC: cs35l56: Convert utility functions to use common data structure
ASoC: cs35l56: Move utility functions to shared file
ASoC: cs35l56: Make common function for control port wait
ASoC: cs35l56: Make a common function to shutdown the DSP
ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier

 include/sound/cs35l56.h           |  29 +-
 sound/pci/hda/Kconfig             |  31 +
 sound/pci/hda/Makefile            |   6 +
 sound/pci/hda/cs35l56_hda.c       | 995 ++++++++++++++++++++++++++++++
 sound/pci/hda/cs35l56_hda.h       |  48 ++
 sound/pci/hda/cs35l56_hda_i2c.c   |  69 +++
 sound/pci/hda/cs35l56_hda_spi.c   |  68 ++
 sound/pci/hda/hda_auto_parser.h   |   2 +
 sound/pci/hda/hda_generic.h       |   3 +
 sound/soc/codecs/cs35l56-i2c.c    |  14 +-
 sound/soc/codecs/cs35l56-sdw.c    |  72 +--
 sound/soc/codecs/cs35l56-shared.c | 458 +++++++++++++-
 sound/soc/codecs/cs35l56-spi.c    |  10 +-
 sound/soc/codecs/cs35l56.c        | 648 ++++---------------
 sound/soc/codecs/cs35l56.h        |  15 +-
 15 files changed, 1877 insertions(+), 591 deletions(-)
 create mode 100644 sound/pci/hda/cs35l56_hda.c
 create mode 100644 sound/pci/hda/cs35l56_hda.h
 create mode 100644 sound/pci/hda/cs35l56_hda_i2c.c
 create mode 100644 sound/pci/hda/cs35l56_hda_spi.c
Signature · 1 line
2.30.2