Skip to content

RFC dmaengine: edma: add freescale edma v3 support

Frank Li imx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest12 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12dmaengine: fsl-edma: clean up EXPORT_SYMBOL_GPL in fsl-edma-common.cdrivers/dma/Makefile drivers/dma/fsl-edma-common.c drivers/dma/fsl-edma-main.c +1 more+4 -200 replies
2/12dmaengine: fsl-edma: clean up fsl_edma_irq_exit()drivers/dma/fsl-edma-main.c+0 -120 replies
3/12dmaengine: fsl-edma: transition from bool fields to bitmask flags in drvdatadrivers/dma/fsl-edma-common.c drivers/dma/fsl-edma-common.h drivers/dma/fsl-edma-main.c+7 -60 replies
4/12dmaengine: fsl-edma: remove v3 from enum edma_versiondrivers/dma/fsl-edma-common.c drivers/dma/fsl-edma-common.h drivers/dma/fsl-edma-main.c+4 -40 replies
5/12dmaengine: fsl-edma: move common IRQ handler to common.cdrivers/dma/fsl-edma-common.c drivers/dma/fsl-edma-common.h drivers/dma/fsl-edma-main.c +1 more+37 -560 replies
6/12dmaengine: fsl-edma: simply ATTR_DSIZE and ATTR_SSIZE by using ffs()drivers/dma/fsl-edma-common.c drivers/dma/fsl-edma-common.h+8 -230 replies
7/12dmaengine: fsl-edma: refactor using devm_clk_get_enableddrivers/dma/fsl-edma-main.c+2 -170 replies
8/12dmaengine: fsl-edma: move clearing of register interrupt into setup_irq functiondrivers/dma/fsl-edma-main.c+4 -10 replies
9/12dmaengine: fsl-edma: refactor chan_name setup and safetydrivers/dma/fsl-edma-common.h drivers/dma/fsl-edma-main.c+4 -30 replies
10/12dmaengine: fsl-edma: move tcd into struct fsl_dma_chandrivers/dma/fsl-edma-common.c drivers/dma/fsl-edma-common.h drivers/dma/fsl-edma-main.c +1 more+42 -280 replies
11/12dmaengine: fsl-edma: integrate v3 supportdrivers/dma/fsl-edma-common.c drivers/dma/fsl-edma-common.h drivers/dma/fsl-edma-main.c+456 -290 replies
12/12dt-bindings: fsl-dma: fsl-edma: add edma3 compatible stringDocumentation/devicetree/bindings/dma/fsl,edma.yaml+19 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/12] dmaengine: edma: add freescale edma v3 support

This patch series introduces support for the eDMA version 3 from Freescale. The eDMA v3 brings alterations in the register layout, particularly, the separation of channel control registers into different channels. The Transfer Control Descriptor (TCD) layout, however, remains identical with only the offset being changed.

The first nine patches aim at tidying up the existing Freescale eDMA code and laying the groundwork for the integration of eDMA v3 support.

Patch 1-10:
These patches primarily focus on cleaning up and refactoring the existing fsl_edma driver code. This is to accommodate the upcoming changes and new features introduced with the eDMA v3.

Patch 11:
This patch introduces support for eDMA v3. In addition, this patch has been designed with an eye towards future upgradability, specifically for transitioning to eDMA v5. The latter involves a significant upgrade where the TCD address would need to support 64 bits.

Patch 12:
This patch focuses on the device tree bindings and their modifications to properly handle and integrate the changes brought about by eDMA v3

----
include v5 TCD64 change at
https://bitbucket.sw.nxp.com/projects/IMX/repos/linux-test-testbuild/pull-requests?create&sourceBranch=refs%2Fheads%2Fedma_upstream_prep_v5

without v5 change
https://bitbucket.sw.nxp.com/projects/IMX/repos/linux-test-testbuild/pull-requests?create&sourceBranch=refs%2Fheads%2Fedma_upstream_prep_v4

These 12 patches were first sets, which try to upstream. After finished then upstream dts part.
v5 need be wait for imx95 tapeout.
----

Frank Li (12):

1   dmaengine: fsl-edma: clean up EXPORT_SYMBOL_GPL in fsl-edma-common.c
2   dmaengine: fsl-edma: clean up fsl_edma_irq_exit()
3   dmaengine: fsl-edma: transition from bool fields to bitmask flags in
     drvdata
4   dmaengine: fsl-edma: remove v3 from enum edma_version
5   dmaengine: fsl-edma: move common IRQ handler to common.c
6   dmaengine: fsl-edma: simply ATTR_DSIZE and ATTR_SSIZE by using ffs()
7   dmaengine: fsl-edma: refactor using devm_clk_get_enabled
8   dmaengine: fsl-edma: move clearing of register interrupt into
     setup_irq function
9   dmaengine: fsl-edma: refactor chan_name setup and safety
10  dmaengine: fsl-edma: move tcd into struct fsl_dma_chan
11  dmaengine: fsl-edma: integrate v3 support
12  dt-bindings: fsl-dma: fsl-edma: add edma3 compatible string
 .../devicetree/bindings/dma/fsl,edma.yaml     |  19 ++
 drivers/dma/Makefile                          |   6 +-
 drivers/dma/fsl-edma-common.c                 | 267 +++++++++++----
 drivers/dma/fsl-edma-common.h                 | 119 ++++++-
 drivers/dma/{fsl-edma.c => fsl-edma-main.c}   | 323 ++++++++++++++----
 drivers/dma/{mcf-edma.c => mcf-edma-main.c}   |  34 +-
 6 files changed, 578 insertions(+), 190 deletions(-)
 rename drivers/dma/{fsl-edma.c => fsl-edma-main.c} (62%)
 rename drivers/dma/{mcf-edma.c => mcf-edma-main.c} (91%)
Signature · 1 line
2.34.1