Skip to content

RFC Draft: Update Xe uAPI for 32-bit compat, invasively

Christopher Snowhill intel-xe 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 0 repliesNew

v3 from the cover letter

Redid everything, maybe this one will be a little more permanent.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/xe: Reshuffle all of the uAPI structsinclude/uapi/drm/xe_drm.h+45 -190 replies
2/2drm/xe: Validate uAPI padding and reserved fieldsdrivers/gpu/drm/xe/xe_bo.c drivers/gpu/drm/xe/xe_engine.c drivers/gpu/drm/xe/xe_exec.c +6 more+50 -150 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Intel-xe] [RFC PATCH 0/2] Draft: Update Xe uAPI for 32-bit compat, invasively

This attempt brings in Maarten Lankhorst's original uAPI update, with suggested changes made to make up the difference. As long as we're attempting to bring up 32-bit compat capability, we may as well go whole hog and just break things. Better that way than to deal with the mess later.

Also introduces field validation against all of the padding and reserved fields, which must be zero, in a separate commit.

This is the invasive update, as a draft, for comment and examination. It's probably not going to be applied any time soon, but it's here, and it's been updated based on the comments against the original invasive attempt.

v3:
Redid everything, maybe this one will be a little more permanent.
v2:
Removed extensions checks where there were none originally. (José) Moved extraneous parentheses to the correct places. (Lucas)

Christopher Snowhill (2):
drm/xe: Reshuffle all of the uAPI structs drm/xe: Validate uAPI padding and reserved fields

 drivers/gpu/drm/xe/xe_bo.c              |  6 ++-
 drivers/gpu/drm/xe/xe_engine.c          | 18 +++++--
 drivers/gpu/drm/xe/xe_exec.c            |  4 +-
 drivers/gpu/drm/xe/xe_mmio.c            |  3 +-
 drivers/gpu/drm/xe/xe_query.c           |  3 +-
 drivers/gpu/drm/xe/xe_sync.c            |  4 +-
 drivers/gpu/drm/xe/xe_vm.c              | 21 ++++++--
 drivers/gpu/drm/xe/xe_vm_madvise.c      |  3 +-
 drivers/gpu/drm/xe/xe_wait_user_fence.c |  3 +-
 include/uapi/drm/xe_drm.h               | 64 +++++++++++++++++--------
 10 files changed, 95 insertions(+), 34 deletions(-)
Signature · 1 line
2.40.1