Skip to content

net/tls: fixes for NVMe-over-TLS

Hannes Reinecke linux-nvme netdev 10 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest6 patches 0 repliesApplied 6/6
  2. v86 patches 9 repliesSuperseded
  3. v7 posting 2/26 patches 8 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v7 posting 1/26 patches1 replySuperseded
v65 patches18 repliesSuperseded
v54 patches9 repliesSuperseded
v44 patches4 repliesSuperseded
v34 patches3 repliesSuperseded
v24 patches4 repliesSuperseded
v13 patches1 replySuperseded

Changes to v2 from the cover letter

- Bail out on conflicting message flags
- Rework flag handling

Patches in v9 All 6 applied

#Subject and filesSizeRepliesApplied
1/6net/tls: handle MSG_EOR for tls_sw TX flownet/tls/tls_sw.c+4 -10 repliesApplied
2/6net/tls: handle MSG_EOR for tls_device TX flownet/tls/tls_device.c+5 -10 repliesApplied
3/6selftests/net/tls: add test for MSG_EORtools/testing/selftests/net/tls.c+11 -00 repliesApplied
4/6net/tls: Use tcp_read_sock() instead of ops->read_sock()net/tls/tls_strp.c+1 -20 repliesApplied
5/6net/tls: split tls_rx_reader_locknet/tls/tls_sw.c+22 -160 repliesApplied
6/6net/tls: implement ->read_sock()net/tls/tls.h net/tls/tls_main.c net/tls/tls_sw.c+103 -00 repliesApplied

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJakub KicinskiSagi Grimberg
1/6R-b
2/6R-b
3/6R-b R-b
4/6R-b
5/6R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCHv9 0/6] net/tls: fixes for NVMe-over-TLS

Hi all,

here are some small fixes to get NVMe-over-TLS up and running. The first set are just minor modifications to have MSG_EOR handled for TLS, but the second set implements the ->read_sock() callback for tls_sw.
The ->read_sock() callbacks return -EIO when encountering any TLS Alert message, but as that's the default behaviour anyway I guess we can get away with it.

As usual, comments and reviews are welcome.

Changes to the original submission:
- Add a testcase for MSG_EOR handling

Changes to v2:
- Bail out on conflicting message flags
- Rework flag handling

Changes to v3:
- Return -EINVAL on conflicting flags
- Rebase on top of net-next

Changes to v4:
- Add tlx_rx_reader_lock() to read_sock
- Add MSG_EOR handling to tls_sw_readpages()

Changes to v5:
- Rebase to latest upstream
- Split tls_rx_reader_lock() as suggested by Sagi

Changes to v6:
- Fixup tls_strp_read_copyin() to avoid infinite recursion in tls_read_sock()
- Rework tls_read_sock() to read all available data

Changes to v7:
- Include reviews from Jakub

Changes to v8:
- Use tls_read_flush_backlog()

Hannes Reinecke (6):
net/tls: handle MSG_EOR for tls_sw TX flow net/tls: handle MSG_EOR for tls_device TX flow selftests/net/tls: add test for MSG_EOR net/tls: Use tcp_read_sock() instead of ops->read_sock() net/tls: split tls_rx_reader_lock
net/tls: implement ->read_sock()

 net/tls/tls.h                     |   2 +
 net/tls/tls_device.c              |   6 +-
 net/tls/tls_main.c                |   2 +
 net/tls/tls_strp.c                |   3 +-
 net/tls/tls_sw.c                  | 142 ++++++++++++++++++++++++++----
 tools/testing/selftests/net/tls.c |  11 +++
 6 files changed, 146 insertions(+), 20 deletions(-)
Signature · 1 line
2.35.3