net/tls: fixes for NVMe-over-TLS
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest6 patches 0 repliesApplied 6/6
- v86 patches 9 repliesSuperseded
- v7 posting 2/26 patches 8 repliesSuperseded
Earlier versions · 7
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v7 posting 1/2 | 6 patches | 1 reply | Superseded | |
| v6 | 5 patches | 18 replies | Superseded | |
| v5 | 4 patches | 9 replies | Superseded | |
| v4 | 4 patches | 4 replies | Superseded | |
| v3 | 4 patches | 3 replies | Superseded | |
| v2 | 4 patches | 4 replies | Superseded | |
| v1 | 3 patches | 1 reply | Superseded |
Changes to v2 from the cover letter
- Bail out on conflicting message flags
- Rework flag handling
Patches in v9 All 6 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | net/tls: handle MSG_EOR for tls_sw TX flownet/ | +4 | 0 replies | Applied |
| 2/6 | net/tls: handle MSG_EOR for tls_device TX flownet/ | +5 | 0 replies | Applied |
| 3/6 | selftests/net/tls: add test for MSG_EORtools/ | +11 | 0 replies | Applied |
| 4/6 | net/tls: Use tcp_read_sock() instead of ops->read_sock()net/ | +1 | 0 replies | Applied |
| 5/6 | net/tls: split tls_rx_reader_locknet/ | +22 | 0 replies | Applied |
| 6/6 | net/tls: implement ->read_sock()net/ net/ net/ | +103 | 0 replies | Applied |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Jakub Kicinski | Sagi Grimberg |
|---|---|---|
| 1/6 | R-b | |
| 2/6 | R-b | |
| 3/6 | R-b | R-b |
| 4/6 | R-b | |
| 5/6 | R-b | |
| 6/6 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHv9 0/6] net/tls: fixes for NVMe-over-TLS
Hi all,
here are some small fixes to get NVMe-over-TLS up and running. The first set are just minor modifications to have MSG_EOR handled for TLS, but the second set implements the ->read_sock() callback for tls_sw.
The ->read_sock() callbacks return -EIO when encountering any TLS Alert message, but as that's the default behaviour anyway I guess we can get away with it.
As usual, comments and reviews are welcome.
Changes to the original submission:
- Add a testcase for MSG_EOR handling
Changes to v2:
- Bail out on conflicting message flags
- Rework flag handling
Changes to v3:
- Return -EINVAL on conflicting flags
- Rebase on top of net-next
Changes to v4:
- Add tlx_rx_reader_lock() to read_sock
- Add MSG_EOR handling to tls_sw_readpages()
Changes to v5:
- Rebase to latest upstream
- Split tls_rx_reader_lock() as suggested by Sagi
Changes to v6:
- Fixup tls_strp_read_copyin() to avoid infinite recursion in tls_read_sock()
- Rework tls_read_sock() to read all available data
Changes to v7:
- Include reviews from Jakub
Changes to v8:
- Use tls_read_flush_backlog()
Hannes Reinecke (6):
net/tls: handle MSG_EOR for tls_sw TX flow net/tls: handle MSG_EOR for tls_device TX flow selftests/net/tls: add test for MSG_EOR net/tls: Use tcp_read_sock() instead of ops->read_sock() net/tls: split tls_rx_reader_lock
net/tls: implement ->read_sock()
net/tls/tls.h | 2 + net/tls/tls_device.c | 6 +- net/tls/tls_main.c | 2 + net/tls/tls_strp.c | 3 +- net/tls/tls_sw.c | 142 ++++++++++++++++++++++++++---- tools/testing/selftests/net/tls.c | 11 +++ 6 files changed, 146 insertions(+), 20 deletions(-)
Signature · 1 line
2.35.3