Skip to content

watchdog: Cleanup / fixes after buddy series v5 reviews

Douglas Anderson linux-perf-users linuxppc-dev lkml sparclinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 10 repliesIn review 8 of 10 applied

Patches in v1 8 of 10 applied

#Subject and filesSizeRepliesApplied
1/10watchdog/hardlockup: Keep kernel.nmi_watchdog sysctl as 0444 if probe failsinclude/linux/nmi.h kernel/watchdog.c+20 -161 reply
2/10watchdog/hardlockup: HAVE_NMI_WATCHDOG must implement watchdog_hardlockup_probe()arch/Kconfig arch/sparc/kernel/nmi.c kernel/watchdog.c+7 -141 replyApplied
3/10watchdog/hardlockup: Don't use raw_cpu_ptr() in watchdog_hardlockup_kick()kernel/watchdog.c+1 -11 replyApplied
4/10watchdog/hardlockup: In watchdog_hardlockup_check() use cpumask_copy()kernel/watchdog.c+3 -11 replyApplied
5/10watchdog/hardlockup: remove softlockup comment in touch_nmi_watchdog()include/linux/nmi.h+0 -41 replyApplied
6/10watchdog/buddy: Cleanup how watchdog_buddy_check_hardlockup() is calledinclude/linux/nmi.h kernel/watchdog.c kernel/watchdog_buddy.c+10 -111 replyApplied
7/10watchdog/buddy: Don't copy the cpumask in watchdog_next_cpu()kernel/watchdog_buddy.c+2 -31 replyApplied
8/10watchdog/buddy: Simplify the dependency for HARDLOCKUP_DETECTOR_PREFER_BUDDYlib/Kconfig.debug+1 -11 replyApplied
9/10watchdog/hardlockup: Move SMP barriers from common code to buddy codekernel/watchdog.c kernel/watchdog_buddy.c+21 -61 replyApplied
10/10watchdog/hardlockup: Rename HAVE_HARDLOCKUP_DETECTOR_NON_ARCH to ..._PERF_OR_BUDDYlib/Kconfig.debug+6 -61 reply

Reviews trailers per patch

9 of 10 patches have a Reviewed-by or Acked-by.

PatchPetr Mladek
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] watchdog: Cleanup / fixes after buddy series v5 reviews

This patch series attempts to finish resolving the feedback received from Petr Mladek on the v5 series I posted. Andrew has already landed v5 so I'm posting this as additional patches.

Probably the only thing that wasn't fully as clean as Petr requested was the Kconfig stuff. I couldn't find a better way to express it without a more major overhaul. In the very least, I renamed "NON_ARCH" to "PERF_OR_BUDDY" in the hopes that will make it marginally better.

Nothing in this series is terribly critical and even the bugfixes are small. However, it does cleanup a few things that were pointed out in review.

Douglas Anderson (10):
watchdog/hardlockup: Keep kernel.nmi_watchdog sysctl as 0444 if probe
fails
watchdog/hardlockup: HAVE_NMI_WATCHDOG must implement
watchdog_hardlockup_probe()
watchdog/hardlockup: Don't use raw_cpu_ptr() in
watchdog_hardlockup_kick()
watchdog/hardlockup: In watchdog_hardlockup_check() use cpumask_copy() watchdog/hardlockup: remove softlockup comment in touch_nmi_watchdog() watchdog/buddy: Cleanup how watchdog_buddy_check_hardlockup() is
called
watchdog/buddy: Don't copy the cpumask in watchdog_next_cpu() watchdog/buddy: Simplify the dependency for
HARDLOCKUP_DETECTOR_PREFER_BUDDY
watchdog/hardlockup: Move SMP barriers from common code to buddy code watchdog/hardlockup: Rename HAVE_HARDLOCKUP_DETECTOR_NON_ARCH to

    ..._PERF_OR_BUDDY
 arch/Kconfig            |  3 +-
 arch/sparc/kernel/nmi.c |  5 +++
 include/linux/nmi.h     | 14 ++-------
 kernel/watchdog.c       | 68 ++++++++++++++++++-----------------------
 kernel/watchdog_buddy.c | 28 ++++++++++++++---
 lib/Kconfig.debug       | 14 ++++-----
 6 files changed, 70 insertions(+), 62 deletions(-)
Signature · 1 line
2.41.0.rc0.172.g3f132b7071-goog