Skip to content

Do not access i915_gem_object members from frontbuffer tracking

Jouni Högander intel-gfx 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 5 repliesIn review
  2. v34 patches 0 repliesSuperseded
  3. v24 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Fix intel_frontbuffer_get return value
- s/front_ret/cur/

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/i915: Add macros to get i915 device from i915_gem_objectdrivers/gpu/drm/i915/display/intel_frontbuffer.c drivers/gpu/drm/i915/gem/i915_gem_object_types.h+12 -91 reply
2/4drm/i915: Add getter/setter for i915_gem_object->frontbufferdrivers/gpu/drm/i915/display/intel_frontbuffer.c drivers/gpu/drm/i915/display/intel_frontbuffer.h drivers/gpu/drm/i915/gem/i915_gem_object.c +2 more+77 -431 reply
3/4drm/i915/display: Remove i915_gem_object_types.h from intel_frontbuffer.hdrivers/gpu/drm/i915/display/intel_frontbuffer.h+0 -11 reply
4/4drm/i915: Add function to clear scanout flag for vmasdrivers/gpu/drm/i915/display/intel_frontbuffer.c drivers/gpu/drm/i915/i915_vma.c drivers/gpu/drm/i915/i915_vma.h+23 -71 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJani NikulaNirmoy DasJeevan B
1/4R-b R-b
2/4R-b
3/4R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [Intel-gfx] [PATCH v4 0/4] Do not access i915_gem_object members from frontbuffer tracking

We are preparing for Xe driver. Binary objects will have differing implementation in Xe driver. Due this we want to remove direct accesses to i915_gem_object members and leave details to binary object implementation.

Cc Jani Nikula <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Nirmoy Das <[email protected]>

v4:
- Fix intel_frontbuffer_get return value
- s/front_ret/cur/
v3:
- Move gem object frontbuffer getter/setter into header file
- operate on and return pointer in defined macros
v2: desribe i915_ggtt_clear_scanout function parameter

Cc Jani Nikula <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Maarten Lankhorst <[email protected]>

Jouni Högander (4):
drm/i915: Add macros to get i915 device from i915_gem_object drm/i915: Add getter/setter for i915_gem_object->frontbuffer drm/i915/display: Remove i915_gem_object_types.h from
intel_frontbuffer.h
drm/i915: Add function to clear scanout flag for vmas

 .../gpu/drm/i915/display/intel_frontbuffer.c  | 46 +++++--------
 .../gpu/drm/i915/display/intel_frontbuffer.h  | 28 --------
 drivers/gpu/drm/i915/gem/i915_gem_object.c    |  4 +-
 drivers/gpu/drm/i915/gem/i915_gem_object.h    | 67 +++++++++++++++++++
 .../gpu/drm/i915/gem/i915_gem_object_types.h  |  3 +
 drivers/gpu/drm/i915/i915_vma.c               | 22 +++++-
 drivers/gpu/drm/i915/i915_vma.h               |  2 +
 7 files changed, 112 insertions(+), 60 deletions(-)
Signature · 1 line
2.34.1