Skip to content

iavf: fix reset task deadlock

Mateusz Palczewski intel-wired-lan 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest5 patches 5 repliesIn review
  2. v94 patches 0 repliesSuperseded

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5iavf: Wait for reset in callbacks which trigger itdrivers/net/ethernet/intel/iavf/iavf.h drivers/net/ethernet/intel/iavf/iavf_ethtool.c drivers/net/ethernet/intel/iavf/iavf_main.c +1 more+68 -171 reply
2/5Revert "iavf: Detach device during reset task"drivers/net/ethernet/intel/iavf/iavf_main.c+2 -111 reply
3/5Revert "iavf: Do not restart Tx queues after reset task failure"drivers/net/ethernet/intel/iavf/iavf_main.c+1 -151 reply
4/5iavf: fix a deadlock caused by rtnl and driver's lock circular dependenciesdrivers/net/ethernet/intel/iavf/iavf.h drivers/net/ethernet/intel/iavf/iavf_main.c drivers/net/ethernet/intel/iavf/iavf_virtchnl.c+85 -321 reply
5/5iavf: fix reset task race with iavf_remove()drivers/net/ethernet/intel/iavf/iavf.h drivers/net/ethernet/intel/iavf/iavf_ethtool.c drivers/net/ethernet/intel/iavf/iavf_main.c +1 more+16 -291 reply

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchMateusz PalczewskiRafal Romanowski
1/5T-b
2/5T-b
3/5T-b
4/5T-b
5/5Singed-off-by T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [Intel-wired-lan] [PATCH iwl-net v10 0/5] iavf: fix reset task deadlock

From: Dawid Wesierski <[email protected]>

Changing the way we handle resets so that the callback operating under the RTNL lock will wait for the reset to finish, the rtnl_lock sensitive functions in reset flow will schedule the netdev update for later. This will eliminate circular dependency with the critical lock.

Ahmed Zaki (2):
iavf: fix a deadlock caused by rtnl and driver's lock circular
dependencies
iavf: fix reset task race with iavf_remove()

Marcin Szycik (3):
iavf: Wait for reset in callbacks which trigger it Revert "iavf: Detach device during reset task"
Revert "iavf: Do not restart Tx queues after reset task failure"

 drivers/net/ethernet/intel/iavf/iavf.h        |   6 +-
 .../net/ethernet/intel/iavf/iavf_ethtool.c    |  39 ++-
 drivers/net/ethernet/intel/iavf/iavf_main.c   | 226 +++++++++++-------
 .../net/ethernet/intel/iavf/iavf_virtchnl.c   |   5 +-
 4 files changed, 172 insertions(+), 104 deletions(-)
Signature · 6 lines
2.31.1

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan