Skip to content

memory-device: Some cleanups

David Hildenbrand qemu-arm qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest10 patches 1 replyIn review
  2. v310 patches 3 repliesSuperseded
  3. v110 patches 21 repliesSuperseded

Changes in v4 from the cover letter

- Added RBs and ACKs

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10memory-device: Unify enabled vs. supported error messageshw/mem/memory-device.c+4 -90 replies
2/10memory-device: Introduce machine_memory_devices_init()hw/mem/memory-device.c include/hw/boards.h+16 -00 replies
3/10hw/arm/virt: Use machine_memory_devices_init()hw/arm/virt.c+1 -80 replies
4/10hw/ppc/spapr: Use machine_memory_devices_init()hw/ppc/spapr.c hw/ppc/spapr_hcall.c+20 -190 replies
5/10hw/loongarch/virt: Use machine_memory_devices_init()hw/loongarch/virt.c+3 -90 replies
6/10hw/i386/pc: Use machine_memory_devices_init()hw/i386/pc.c+5 -120 replies
7/10hw/i386/acpi-build: Rely on machine->device_memory when building SRAThw/i386/acpi-build.c+3 -60 replies
8/10hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZEhw/i386/pc.c include/hw/i386/pc.h+0 -200 replies
9/10memory-device: Refactor memory_device_pre_plug()hw/mem/memory-device.c+14 -140 replies
10/10memory-device: Track used region size in DeviceMemoryStatehw/mem/memory-device.c include/hw/boards.h+5 -190 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéMichael S. TsirkinSong GaoCédric Le Goater
1/10R-b
2/10R-b
3/10R-b
4/10R-b R-b
5/10R-b R-b
6/10R-b A-b
7/10R-b A-b
8/10R-b A-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/10] memory-device: Some cleanups

Essentially a resend with ACKs/RBs. If I don't get any more comments I'll queue this to my mem-next tree next week.

Working on adding multi-memslot support for virtio-mem (teaching memory device code about memory devices that can consume multiple memslots), I have some preparatory cleanups in my queue that make sense independent of the actual memory-device/virtio-mem extensions.

v3 -> v4:
- Added RBs and ACKs

v2 -> v3:
- "memory-device: Introduce machine_memory_devices_init()" -- Declare the function in hw/boards.h
- "hw/loongarch/virt: Use machine_memory_devices_init()" -- Use VIRT_HIGHMEM_BASE
-- No need to include memory-device.h
- "hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZ"
-- Add more details why it's ok to the patch description
- Adjust to memory_devices_init() -> machine_memory_devices_init()
- Add RBs

v1 -> v2:
- Allocate ms->device_memory only if the size > 0.
- Split it up and include more cleanups

David Hildenbrand (10):
memory-device: Unify enabled vs. supported error messages
memory-device: Introduce machine_memory_devices_init() hw/arm/virt: Use machine_memory_devices_init() hw/ppc/spapr: Use machine_memory_devices_init() hw/loongarch/virt: Use machine_memory_devices_init() hw/i386/pc: Use machine_memory_devices_init() hw/i386/acpi-build: Rely on machine->device_memory when building SRAT hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZE
memory-device: Refactor memory_device_pre_plug()
memory-device: Track used region size in DeviceMemoryState

 hw/arm/virt.c          |  9 +-----
 hw/i386/acpi-build.c   |  9 ++----
 hw/i386/pc.c           | 36 +++-------------------
 hw/loongarch/virt.c    | 12 ++------
 hw/mem/memory-device.c | 69 +++++++++++++++++++-----------------------
 hw/ppc/spapr.c         | 37 +++++++++++-----------
 hw/ppc/spapr_hcall.c   |  2 +-
 include/hw/boards.h    |  4 +++
 include/hw/i386/pc.h   |  1 -
 9 files changed, 67 insertions(+), 112 deletions(-)
Signature · 1 line
2.40.1