Skip to content

s390/vfio-ap: fix hang when mdev attached to guest is removed

Tony Krowiak kvm linux-s390 lkml 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 12 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3vfio: ap: realize the VFIO_DEVICE_GET_IRQ_INFO ioctldrivers/s390/crypto/vfio_ap_ops.c include/uapi/linux/vfio.h+38 -14 replies
2/3vfio: ap: realize the VFIO_DEVICE_SET_IRQS ioctldrivers/s390/crypto/vfio_ap_ops.c drivers/s390/crypto/vfio_ap_private.h+86 -01 reply
3/3s390/vfio-ap: Wire in the vfio_device_ops request callbackdrivers/s390/crypto/vfio_ap_ops.c+21 -01 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchCédric Le GoaterMatthew RosatoAlex Williamson
SeriesR-b
1/3R-b A-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/3] s390/vfio-ap: fix hang when mdev attached to guest is removed

When a user attempts to remove a vfio-ap mediated device attached to a guest, the operation hangs until the mdev's fd is closed by the guest (i.e., the hostdev is detached or the guest is shut down). This patch series provides kernel-side code that allows userspace to set up a communication channel that will allow the vfio_ap device driver to notify userspace when a request to release the mdev is received, so that userspace can close the mdev fd and avoid the hang. The patch series provides the following:

1. Introduces code to handle the VFIO_DEVICE_GET_IRQ_INFO and VFIO_DEVICE_SET_IRQS ioctl calls to set the eventfd_ctx for signaling a device request to userspace.

2. Wires up the VFIO bus driver callback to request a release of the mdev. When invoked, the vfio_ap device driver will use the eventfd_ctx set up in #1 to signal a request to userspace to release the mdev.

Note:
----
If a user subsequently attempts to restart the guest or re-attach the mdev, the operation will fail with a message indicating the domain is already active. This is a libvirt problem resolved with the following commit:

commit ebd004a03dbd ("security: do not remember/recall labels for VFIO MDEVs")

Tony Krowiak (3):
vfio: ap: realize the VFIO_DEVICE_GET_IRQ_INFO ioctl
vfio: ap: realize the VFIO_DEVICE_SET_IRQS ioctl s390/vfio-ap: Wire in the vfio_device_ops request callback

 drivers/s390/crypto/vfio_ap_ops.c     | 134 +++++++++++++++++++++++++-
 drivers/s390/crypto/vfio_ap_private.h |   3 +
 include/uapi/linux/vfio.h             |   9 ++
 3 files changed, 145 insertions(+), 1 deletion(-)
Signature · 1 line
2.31.1