Introduce cmpxchg128() -- aka. the demise of cmpxchg_double()
Status from this message: The following commit has been merged into the locking/core branch of tip:
Get series with b4
b4 am [email protected]Versions newest first
Since v3 from the cover letter
- unbreak everything that does *NOT* have cmpxchg128()
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | cyrpto/b128ops: Remove struct u128include/ | +3 | 0 replies | |
| 2/12 | types: Introduce [us]128include/ include/ lib/ +1 more | +9 | 0 replies | |
| 3/12 | arch: Introduce arch_{,try_}_cmpxchg128{,_local}()arch/ arch/ arch/ +3 more | +177 | 0 replies | |
| 4/12 | instrumentation: Wire up cmpxchg128()include/ include/ scripts/ +1 more | +183 | 0 replies | |
| 5/12 | percpu: Add {raw,this}_cpu_try_cmpxchg()include/ include/ | +128 | 3 replies | |
| 6/12 | percpu: Wire up cmpxchg128arch/ arch/ arch/ +4 more | +240 | 0 replies | |
| 7/12 | percpu: #ifndef __SIZEOF_INT128__include/ include/ | +63 | 17 replies | |
| 8/12 | x86,amd_iommu: Replace cmpxchg_double()drivers/ drivers/ | +11 | 0 replies | |
| 9/12 | x86,intel_iommu: Replace cmpxchg_double()drivers/ include/ | +68 | 0 replies | |
| 10/12 | slub: Replace cmpxchg_double()include/ mm/ mm/ | +137 | 0 replies | |
| 11/12 | arch: Remove cmpxchg_doubleDocumentation/ arch/ arch/ +12 more | +5 | 0 replies | |
| 12/12 | s390/cpum_sf: Convert to cmpxchg128()arch/ arch/ | +4 | 0 replies |
Reviews trailers per patch
10 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Arnd Bergmann | Heiko Carstens | Herbert Xu | Mark Rutland | Vlastimil Babka | Hyeonggon Yoo | Lu Baolu | Vasant Hegde | Helge Deller |
|---|---|---|---|---|---|---|---|---|---|
| Series | R-b T-b | ||||||||
| 1/12 | R-b | A-b | |||||||
| 2/12 | R-b | A-b | |||||||
| 3/12 | R-b | A-b | A-b | ||||||
| 4/12 | R-b | A-b | |||||||
| 5/12 | |||||||||
| 6/12 | |||||||||
| 7/12 | T-b | A-b | |||||||
| 8/12 | R-b | T-b | |||||||
| 9/12 | R-b | R-b | |||||||
| 10/12 | R-b | A-b | A-b | ||||||
| 11/12 | R-b | A-b | |||||||
| 12/12 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 9 reviewers.
Cover letter [PATCH 00/12] Introduce cmpxchg128() -- aka. the demise of cmpxchg_double()
Hi!
After much breaking of things, find here the improved version.
Since v3:
- unbreak everything that does *NOT* have cmpxchg128()
Notably this_cpu_cmpxchg_double() is used unconditionally by SLUB which means that this_cpu_try_cmpxchg128() needs to be unconditionally available on all 64bit architectures.
- fixed up x86/x86_64 cmpxchg{8,16}b emulation for this_cpu_cmpxchg{64,128}()
- introduce {raw,this}_cpu_try_cmpxchg*()
- add fallback for !__SIZEOF_INT128__ 64bit architectures
Sadly there are supported 64bit architecture/compiler combinations that do not have __SIZEOF_INT128__, specifically it was found that HPPA64 only added this with GCC-11.
this is yuck, and ideally we'd simply raise compiler requirements, but this 'works'.
My plan is to re-add this to tip/locking/core and thus -next later this week.
Also available at:
git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git locking/core
--- Documentation/core-api/this_cpu_ops.rst | 2 - arch/arm64/include/asm/atomic_ll_sc.h | 56 +++--- arch/arm64/include/asm/atomic_lse.h | 39 ++--- arch/arm64/include/asm/cmpxchg.h | 48 ++---- arch/arm64/include/asm/percpu.h | 30 ++-- arch/s390/include/asm/cmpxchg.h | 32 +--- arch/s390/include/asm/cpu_mf.h | 2 +- arch/s390/include/asm/percpu.h | 34 ++-- arch/s390/kernel/perf_cpum_sf.c | 16 +- arch/x86/include/asm/cmpxchg.h | 25 --- arch/x86/include/asm/cmpxchg_32.h | 2 +- arch/x86/include/asm/cmpxchg_64.h | 63 ++++++- arch/x86/include/asm/percpu.h | 102 ++++++----- arch/x86/lib/Makefile | 3 +- arch/x86/lib/cmpxchg16b_emu.S | 43 +++-- arch/x86/lib/cmpxchg8b_emu.S | 67 ++++++-- drivers/iommu/amd/amd_iommu_types.h | 9 +- drivers/iommu/amd/iommu.c | 10 +- drivers/iommu/intel/irq_remapping.c | 8 +- include/asm-generic/percpu.h | 257 ++++++++++++++++++++++------ include/crypto/b128ops.h | 14 +- include/linux/atomic/atomic-arch-fallback.h | 95 +++++++++- include/linux/atomic/atomic-instrumented.h | 93 ++++++++-- include/linux/dmar.h | 125 +++++++------- include/linux/percpu-defs.h | 45 ++--- include/linux/slub_def.h | 12 +- include/linux/types.h | 12 ++ include/uapi/linux/types.h | 4 + lib/crypto/curve25519-hacl64.c | 2 - lib/crypto/poly1305-donna64.c | 2 - mm/slab.h | 53 +++++- mm/slub.c | 139 +++++++++------ scripts/atomic/gen-atomic-fallback.sh | 4 +- scripts/atomic/gen-atomic-instrumented.sh | 19 +- 34 files changed, 952 insertions(+), 515 deletions(-)