Skip to content

localize functions where possible

Stephen Hemminger bridge netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7utils: make local cmdline functions staticinclude/utils.h lib/utils.c+3 -60 replies
2/7libnetlink: drop unused rtnl_talk_iovinclude/libnetlink.h lib/libnetlink.c+0 -90 replies
3/7bridge: make print_vlan_info staticbridge/br_common.h bridge/vlan.c+2 -21 reply
4/7rt_names: drop unused rtnl_addrprot_a2ninclude/rt_names.h lib/rt_names.c+0 -340 replies
5/7ip: make print_rta_gateway staticip/ip_common.h ip/iproute.c+1 -30 replies
6/7xfrm: make xfrm_stat_print_nokeys staticip/xfrm.h ip/xfrm_state.c+1 -20 replies
7/7rdma: make rd_attr_check staticrdma/rdma.h rdma/utils.c+1 -20 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchNikolay Aleksandrov
1/7
2/7
3/7A-b
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH iproute2 0/7] localize functions where possible

This is the result of using a script to examine where functions are defined in one file but not used in any other file. Found some dead code in process.

Stephen Hemminger (7):
utils: make local cmdline functions static
libnetlink: drop unused rtnl_talk_iov
bridge: make print_vlan_info static
rt_names: drop unused rtnl_addrprot_a2n
ip: make print_rta_gateway static
xfrm: make xfrm_stat_print_nokeys static
rdma: make rd_attr_check static

 bridge/br_common.h   |  1 -
 bridge/vlan.c        |  3 ++-
 include/libnetlink.h |  3 ---
 include/rt_names.h   |  1 -
 include/utils.h      |  3 ---
 ip/ip_common.h       |  2 --
 ip/iproute.c         |  2 +-
 ip/xfrm.h            |  1 -
 ip/xfrm_state.c      |  2 +-
 lib/libnetlink.c     |  6 ------
 lib/rt_names.c       | 33 ---------------------------------
 lib/utils.c          |  6 +++---
 rdma/rdma.h          |  1 -
 rdma/utils.c         |  2 +-
 14 files changed, 8 insertions(+), 58 deletions(-)
Signature · 1 line
2.39.2