Skip to content

Page table fence

Philip Yang amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/amdgpu: Implement page table BO fencedrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +1 more+52 -02 replies
2/4drm/amdkfd: Signal page table fence after KFD flush tlbdrivers/gpu/drm/amd/amdkfd/kfd_process.c+5 -08 replies
3/4drm/amdgpu: Signal page table fence after gfx vm flushdrivers/gpu/drm/amd/amdgpu/amdgpu_ib.c+7 -01 reply
4/4drm/amdgpu: Add fence to the freed page table BOsdrivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c+22 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Page table fence

This patch series to fix GPU generate random no-retry fault on APU with XNACK on.

If updating GPU page table to use PDE0 as PTE, for example unmap 2MB align virtual address, then map same virtual address using transparent 2MB huge page, we free the PTE BO first and then flush TLB.

If XNACK ON, H/W may access the freed old PTE page before TLB is flushed. On APU, the freed PTE BO system memory page maybe used and the content is changed, this causes H/W enerates unexpected no-retry fault.

The fix is to add fence to the freed page table BO, and then signal the fence after TLB is flushed to really free the page table BO page.

Philip Yang (4):
drm/amdgpu: Implement page table BO fence drm/amdkfd: Signal page table fence after KFD flush tlb drm/amdgpu: Signal page table fence after gfx vm flush drm/amdgpu: Add fence to the freed page table BOs

 drivers/gpu/drm/amd/amdgpu/amdgpu.h       |  2 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 45 +++++++++++++++++++++++
 drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c    |  7 ++++
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c    |  4 ++
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h    |  1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 33 +++++++++++------
 drivers/gpu/drm/amd/amdkfd/kfd_process.c  |  5 +++
 7 files changed, 86 insertions(+), 11 deletions(-)
Signature · 1 line
2.35.1